From 88608c605f7ee53f98595c4e09d9aa6c1956c58b Mon Sep 17 00:00:00 2001
From: Harpritsinh Sisodiya <hsi@odoo.com>
Date: Mon, 4 May 2020 06:09:34 +0000
Subject: [PATCH] [IMP] web: kanban: archive last column records

Before this commit, the action helper (if any) was not displayed when
archiving all records of the last non empty column of a kanban view
(making empty that view).

With the present commit, the action helper is now correctly displayed in
that situation.

Task ID: 2247788

closes odoo/odoo#50557

Signed-off-by: Mathieu Duckerts-Antoine <Polymorphe57@users.noreply.github.com>
Co-authored-by: Mohammed Shekha <msh@odoo.com>
---
 .../src/js/views/kanban/kanban_controller.js  |  5 +-
 addons/web/static/tests/views/kanban_tests.js | 55 +++++++++++++++++++
 2 files changed, 59 insertions(+), 1 deletion(-)

diff --git a/addons/web/static/src/js/views/kanban/kanban_controller.js b/addons/web/static/src/js/views/kanban/kanban_controller.js
index e872fff811f..1b6e6301906 100644
--- a/addons/web/static/src/js/views/kanban/kanban_controller.js
+++ b/addons/web/static/src/js/views/kanban/kanban_controller.js
@@ -522,7 +522,10 @@ var KanbanController = BasicController.extend({
             prom.then(function (dbID) {
                 var data = self.model.get(dbID);
                 if (data) {  // Could be null if a wizard is returned for example
-                    self.renderer.updateColumn(dbID, data);
+                    self.model.reload(self.handle).then(function () {
+                        const state = self.model.get(self.handle);
+                        self.renderer.updateColumn(dbID, data, { state });
+                    });
                 }
             });
         }
diff --git a/addons/web/static/tests/views/kanban_tests.js b/addons/web/static/tests/views/kanban_tests.js
index 6491976fb79..ed005600d18 100644
--- a/addons/web/static/tests/views/kanban_tests.js
+++ b/addons/web/static/tests/views/kanban_tests.js
@@ -3716,6 +3716,61 @@ QUnit.module('Views', {
         kanban.destroy();
     });
 
+    QUnit.test('no content helper when archive all records in kanban group', async function (assert) {
+        assert.expect(3);
+
+        // add active field on partner model to have archive option
+        this.data.partner.fields.active = {string: 'Active', type: 'boolean', default: true};
+        // remove last records to have only one column
+        this.data.partner.records = this.data.partner.records.slice(0, 3);
+
+        const kanban = await createView({
+            View: KanbanView,
+            model: 'partner',
+            data: this.data,
+            arch: `<kanban class="o_kanban_test">
+                        <field name="active"/>
+                        <field name="bar"/>
+                        <templates>
+                            <t t-name="kanban-box">
+                               <div><field name="foo"/></div>
+                            </t>
+                        </templates>
+                    </kanban>`,
+            viewOptions: {
+                action: {
+                    help: '<p class="hello">click to add a partner</p>'
+                }
+            },
+            groupBy: ['bar'],
+            mockRPC: function (route, args) {
+                if (route === '/web/dataset/call_kw/partner/action_archive') {
+                    const partnerIDS = args.args[0];
+                    const records = this.data.partner.records;
+                    _.each(partnerIDS, function (partnerID) {
+                        _.find(records, function (record) {
+                            return record.id === partnerID;
+                        }).active = false;
+                    });
+                    return Promise.resolve();
+                }
+                return this._super.apply(this, arguments);
+            },
+        });
+
+        // check that the (unique) column contains 3 records
+        assert.containsN(kanban, '.o_kanban_group:last .o_kanban_record', 3);
+
+        // archive the records of the last column
+        testUtils.kanban.toggleGroupSettings($(kanban.el.querySelector('.o_kanban_group'))); // we should change the helper
+        await testUtils.dom.click(kanban.el.querySelector('.o_kanban_group .o_column_archive_records'));
+        assert.containsOnce(document.body, '.modal');
+        await testUtils.modal.clickButton('Ok');
+        // check no content helper is exist
+        assert.containsOnce(kanban, '.o_view_nocontent');
+        kanban.destroy();
+    });
+
     QUnit.test('no content helper when no data', async function (assert) {
         assert.expect(3);