From 87e968a45ad2d5d92dd170d52ae0bd0bf174a924 Mon Sep 17 00:00:00 2001
From: Denis Ledoux <dle@odoo.com>
Date: Tue, 2 Aug 2022 13:29:44 +0000
Subject: [PATCH] [IMP] purchase: move group inside the view

The goal being to get rid of the `groups_id` feature for backend views

Part-of: odoo/odoo#98551
---
 addons/purchase/views/account_move_views.xml | 34 +++++++++++---------
 1 file changed, 18 insertions(+), 16 deletions(-)

diff --git a/addons/purchase/views/account_move_views.xml b/addons/purchase/views/account_move_views.xml
index 24b1c235a87..03d427ea12b 100644
--- a/addons/purchase/views/account_move_views.xml
+++ b/addons/purchase/views/account_move_views.xml
@@ -4,39 +4,41 @@
         <field name="name">account.move.inherit.purchase</field>
         <field name="model">account.move</field>
         <field name="inherit_id" ref="account.view_move_form"/>
-        <field name="groups_id" eval="[(4, ref('purchase.group_purchase_user'))]"/>
         <field name="arch" type="xml">
             <!-- Auto-complete could be done from either a bill either a purchase order -->
             <field name="invoice_vendor_bill_id" position="after">
-                <field name="purchase_id" invisible="1"/>
-                <label for="purchase_vendor_bill_id" string="Auto-Complete" class="oe_edit_only"
-                       attrs="{'invisible': ['|', ('state','!=','draft'), ('move_type', '!=', 'in_invoice')]}" />
-                <field name="purchase_vendor_bill_id" nolabel="1"
-                       attrs="{'invisible': ['|', ('state','!=','draft'), ('move_type', '!=', 'in_invoice')]}"
-                       class="oe_edit_only"
-                       domain="partner_id and [('company_id', '=', company_id), ('partner_id.commercial_partner_id', '=', commercial_partner_id)] or [('company_id', '=', company_id)]"
-                       placeholder="Select a purchase order or an old bill"
-                       context="{'show_total_amount': True}"
-                       options="{'no_create': True, 'no_open': True}"/>
+                <t groups="purchase.group_purchase_user">
+                    <field name="purchase_id" invisible="1"/>
+                    <label for="purchase_vendor_bill_id" string="Auto-Complete" class="oe_edit_only"
+                        attrs="{'invisible': ['|', ('state','!=','draft'), ('move_type', '!=', 'in_invoice')]}" />
+                    <field name="purchase_vendor_bill_id" nolabel="1"
+                        attrs="{'invisible': ['|', ('state','!=','draft'), ('move_type', '!=', 'in_invoice')]}"
+                        class="oe_edit_only"
+                        domain="partner_id and [('company_id', '=', company_id), ('partner_id.commercial_partner_id', '=', commercial_partner_id)] or [('company_id', '=', company_id)]"
+                        placeholder="Select a purchase order or an old bill"
+                        context="{'show_total_amount': True}"
+                        options="{'no_create': True, 'no_open': True}"/>
+                </t>
             </field>
             <label name="invoice_vendor_bill_id_label" position="attributes">
-                <attribute name="invisible">1</attribute>
+                <attribute name="groups">!purchase.group_purchase_user</attribute>
             </label>
             <field name="invoice_vendor_bill_id" position="attributes">
-                <attribute name="invisible">1</attribute>
+                <attribute name="groups">!purchase.group_purchase_user</attribute>
             </field>
             <!-- Add link to purchase_line_id to account.move.line -->
             <xpath expr="//field[@name='invoice_line_ids']/tree/field[@name='company_id']" position="after">
-                <field name="purchase_line_id" invisible="1"/>
-                <field name="purchase_order_id" attrs="{'column_invisible': [('parent.move_type', '!=', 'in_invoice')]}" optional="hide"/>
+                <field name="purchase_line_id" groups="purchase.group_purchase_user" invisible="1"/>
+                <field name="purchase_order_id" groups="purchase.group_purchase_user" attrs="{'column_invisible': [('parent.move_type', '!=', 'in_invoice')]}" optional="hide"/>
             </xpath>
             <xpath expr="//field[@name='line_ids']/tree/field[@name='company_id']" position="after">
-                <field name="purchase_line_id" invisible="1"/>
+                <field name="purchase_line_id" groups="purchase.group_purchase_user" invisible="1"/>
             </xpath>
             <xpath expr="//div[@name='button_box']" position="inside">
                 <button class="oe_stat_button"
                         name="action_view_source_purchase_orders"
                         type="object"
+                        groups="purchase.group_purchase_user"
                         icon="fa-pencil-square-o"
                         attrs="{'invisible': ['|', ('purchase_order_count', '=', 0), ('move_type', 'not in', ('out_invoice', 'out_refund', 'in_invoice', 'in_refund', 'out_receipt', 'in_receipt'))]}">
                     <field string="Purchases" name="purchase_order_count" widget="statinfo"/>