From 878ceca988b58d32a4df0663d51157c2c775d16c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Thibault=20Delavall=C3=A9e?= <tde@openerp.com>
Date: Mon, 21 Oct 2013 12:49:12 +0200
Subject: [PATCH] [REV] stages: removed bar_fold and bar_color fields.

After some experiments, having colors does not seem to give an
usable result on statusbar widget. Indeed we need to have the
current stage highlited, and maybe something to tell that some
stages have a special meaning and/or are the end of the pipe.
The closed field already gives that meaning.

Moreover the issue with the statusbar widget is that it indicates
state and action. Having both dimensions with colors / icons
is quite difficult to understand. We therefore stand on a simpler
version of the widget, only with stages and the current stage
highlighted.

bzr revid: tde@openerp.com-20131021104912-8ybhw0svdoghheh3
---
 addons/crm/crm.py                             | 4 ----
 addons/crm/crm_view.xml                       | 5 +----
 addons/hr_recruitment/hr_recruitment.py       | 4 ----
 addons/hr_recruitment/hr_recruitment_view.xml | 5 +----
 addons/project/project.py                     | 4 ----
 addons/project/project_data.xml               | 1 -
 addons/project/project_view.xml               | 5 +----
 7 files changed, 3 insertions(+), 25 deletions(-)

diff --git a/addons/crm/crm.py b/addons/crm/crm.py
index 9331fd2ff9e..7c2c2694c39 100644
--- a/addons/crm/crm.py
+++ b/addons/crm/crm.py
@@ -71,10 +71,6 @@ class crm_case_stage(osv.osv):
         'fold': fields.boolean('Folded in Kanban View',
                                help='This stage is folded in the kanban view when'
                                'there are no records in that stage to display.'),
-        'bar_fold': fields.boolean('Folded in Status Bar',
-                                   help='This stage is folded in the form view when'
-                                   'using the statusbar widget.'),
-        'bar_color': fields.integer('Status Bar Color'),
         'closed': fields.boolean('Closing Stage',
                                  help='Indicates whether this field is the end of'
                                  'the maangement process. This is for example a'
diff --git a/addons/crm/crm_view.xml b/addons/crm/crm_view.xml
index 16debe19eeb..87059b2d4be 100644
--- a/addons/crm/crm_view.xml
+++ b/addons/crm/crm_view.xml
@@ -99,13 +99,10 @@
                             <field name="sequence"/>
                             <field name="type"/>
                             <field name="probability"/>
-                            <field name="closed"/>
-                            <field name="case_default"/>
                         </group>
                         <group>
                             <field name="fold"/>
-                            <field name="bar_fold"/>
-                            <field name="bar_color"/>
+                            <field name="closed"/>
                             <field name="on_change"/>
                             <field name="case_default" groups="base.group_multi_salesteams"/>
                         </group>
diff --git a/addons/hr_recruitment/hr_recruitment.py b/addons/hr_recruitment/hr_recruitment.py
index 0af35850311..2e22a765934 100644
--- a/addons/hr_recruitment/hr_recruitment.py
+++ b/addons/hr_recruitment/hr_recruitment.py
@@ -56,10 +56,6 @@ class hr_recruitment_stage(osv.osv):
         'fold': fields.boolean('Folded in Kanban View',
                                help='This stage is folded in the kanban view when'
                                'there are no records in that stage to display.'),
-        'bar_fold': fields.boolean('Folded in Status Bar',
-                                   help='This stage is folded in the form view when'
-                                   'using the statusbar widget.'),
-        'bar_color': fields.integer('Status Bar Color'),
         'closed': fields.boolean('Closing Stage',
                                  help='Indicates whether this field is the end of'
                                  'the maangement process. This is for example a'
diff --git a/addons/hr_recruitment/hr_recruitment_view.xml b/addons/hr_recruitment/hr_recruitment_view.xml
index 66ff4b98887..912419a1874 100644
--- a/addons/hr_recruitment/hr_recruitment_view.xml
+++ b/addons/hr_recruitment/hr_recruitment_view.xml
@@ -343,7 +343,6 @@
                 <field name="name"/>
                 <field name="department_id"/>
                 <field name="fold"/>
-                <field name="bar_fold"/>
             </tree>
         </field>
     </record>
@@ -360,12 +359,10 @@
                         <field name="name"/>
                         <field name="department_id"/>
                         <field name="sequence"/>
-                        <field name="closed"/>
                     </group>
                     <group>
                         <field name="fold"/>
-                        <field name="bar_fold"/>
-                        <field name="bar_color"/>
+                        <field name="closed"/>
                     </group>
                 </group>
                 <separator string="Requirements"/>
diff --git a/addons/project/project.py b/addons/project/project.py
index 8a5774ebb58..79f9c712b04 100644
--- a/addons/project/project.py
+++ b/addons/project/project.py
@@ -44,10 +44,6 @@ class project_task_type(osv.osv):
         'fold': fields.boolean('Folded in Kanban View',
                                help='This stage is folded in the kanban view when'
                                'there are no records in that stage to display.'),
-        'bar_fold': fields.boolean('Folded in Status Bar',
-                                   help='This stage is folded in the form view when'
-                                   'using the statusbar widget.'),
-        'bar_color': fields.integer('Status Bar Color'),
         'closed': fields.boolean('Closing Stage',
                                  help='Indicates whether this field is the end of'
                                  'the maangement process. This is for example a'
diff --git a/addons/project/project_data.xml b/addons/project/project_data.xml
index 78cccb6008c..1f49451a377 100644
--- a/addons/project/project_data.xml
+++ b/addons/project/project_data.xml
@@ -70,7 +70,6 @@
             <field name="name">Cancelled</field>
             <field name="case_default" eval="True"/>
             <field name="fold" eval="True"/>
-            <field name="bar_fold" eval="True"/>
             <field name="closed" eval="True"/>
         </record>
 
diff --git a/addons/project/project_view.xml b/addons/project/project_view.xml
index 4db5c3c9445..eef2701105b 100644
--- a/addons/project/project_view.xml
+++ b/addons/project/project_view.xml
@@ -687,13 +687,11 @@
                         <group>
                             <field name="name"/>
                             <field name="sequence"/>
-                            <field name="closed"/>
                             <field name="case_default"/>
                         </group>
                         <group>
                             <field name="fold"/>
-                            <field name="bar_fold"/>
-                            <field name="bar_color"/>
+                            <field name="closed"/>
                         </group>
                     </group>
                     <field name="description" placeholder="Add a description..."/>
@@ -709,7 +707,6 @@
                     <field name="sequence" widget="handle"/>
                     <field name="name"/>
                     <field name="fold"/>
-                    <field name="bar_fold"/>
                 </tree>
             </field>
         </record>