From 86fd789846dd2a93a25b648acfafa23a5e95414a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?R=C3=A9my=20Voet=20=28ryv=29?= <ryv@odoo.com>
Date: Thu, 15 Oct 2020 15:22:03 +0000
Subject: [PATCH] [FIX] stock: disabled forecasted button new line

In One2many tree of stock.move, the forecasted button trigger
a traceback in case of new line because there isn't a target record.
Also, don't show forecasted information when the state of the move
is 'cancel'.

X-original-commit: a1285d16ff32fb31f202ebe01a6afa83e14b9c14
---
 addons/stock/static/src/js/forecast_widget.js   | 3 +++
 addons/stock/static/src/xml/forecast_widget.xml | 4 ++--
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/addons/stock/static/src/js/forecast_widget.js b/addons/stock/static/src/js/forecast_widget.js
index 3bfc490b2b6..d6d848f2566 100644
--- a/addons/stock/static/src/js/forecast_widget.js
+++ b/addons/stock/static/src/js/forecast_widget.js
@@ -53,6 +53,9 @@ const ForecastWidgetField = AbstractField.extend({
     _onOpenReport: function (ev) {
         ev.preventDefault();
         ev.stopPropagation();
+        if (!this.recordData.id) {
+            return;
+        }
         this._rpc({
             model: 'stock.move',
             method: 'action_product_forecast_report',
diff --git a/addons/stock/static/src/xml/forecast_widget.xml b/addons/stock/static/src/xml/forecast_widget.xml
index 8d282da2452..463e14d6cb7 100644
--- a/addons/stock/static/src/xml/forecast_widget.xml
+++ b/addons/stock/static/src/xml/forecast_widget.xml
@@ -1,11 +1,11 @@
 <?xml version="1.0" encoding="utf-8"?>
 <templates id="template" xml:space="preserve">
     <t t-name="stock.forecastWidget">
-        <span t-if="['draft', 'partially_available', 'assigned'].includes(state)" t-esc="reserved_availability_str"/>
+        <span t-if="['draft', 'partially_available', 'assigned', 'cancel', 'done'].includes(state)" t-esc="reserved_availability_str"/>
         <span t-elif="!forecast_expected_date_str and will_be_fulfilled" class="text-success">Available</span>
         <span t-elif="forecast_expected_date_str and will_be_fulfilled" t-att-class="forecast_is_late ? 'text-danger' : 'text-warning'">Exp <t t-esc="forecast_expected_date_str"/></span>
         <span t-else="" class="text-danger">Not Available</span>
-        <button t-if="product_type == 'product'" class="o_forecast_report_button btn btn-link o_icon_button ml-2" title="Forecasted Report">
+        <button t-if="product_type == 'product'" t-att="id ? {} : {'disabled': ''}" class="o_forecast_report_button btn btn-link o_icon_button ml-2" title="Forecasted Report">
             <i t-attf-class="fa fa-fw fa-area-chart {{ state != 'draft' and (!will_be_fulfilled or forecast_is_late) ? 'text-danger' : '' }}"/>
         </button>
     </t>