diff --git a/addons/hr/i18n/hr.pot b/addons/hr/i18n/hr.pot index 7d01e6fd4fb..7051e1dab9d 100644 --- a/addons/hr/i18n/hr.pot +++ b/addons/hr/i18n/hr.pot @@ -2546,7 +2546,7 @@ msgstr "" #. odoo-python #: code:addons/hr/models/hr_plan_activity_type.py:0 #, python-format -msgid "User of coach of employee %s is not set." +msgid "The user of %s's coach is not set." msgstr "" #. module: hr diff --git a/addons/hr/models/hr_plan_activity_type.py b/addons/hr/models/hr_plan_activity_type.py index cab65ff80f0..572f72504eb 100644 --- a/addons/hr/models/hr_plan_activity_type.py +++ b/addons/hr/models/hr_plan_activity_type.py @@ -44,13 +44,13 @@ class HrPlanActivityType(models.Model): if not employee.coach_id: warning = _('Coach of employee %s is not set.', employee.name) responsible = employee.coach_id.user_id - if not responsible: - warning = _('User of coach of employee %s is not set.', employee.name) + if employee.coach_id and not responsible: + warning = _("The user of %s's coach is not set.", employee.name) elif self.responsible == 'manager': if not employee.parent_id: warning = _('Manager of employee %s is not set.', employee.name) responsible = employee.parent_id.user_id - if not responsible: + if employee.parent_id and not responsible: warning = _("The manager of %s should be linked to a user.", employee.name) elif self.responsible == 'employee': responsible = employee.user_id