From 857ef8f5fd11e40347c62a928d03e514901947bb Mon Sep 17 00:00:00 2001 From: Raphael Collet Date: Mon, 11 Apr 2022 08:10:23 +0000 Subject: [PATCH] [FIX] core: field display_name should be "" instead of False This is a followup of #86567, where we change the computation of display_name to match the values of name_get(). Forcing its value to False instead of the empty string causes many regressions in frontend applications like website_blog. closes odoo/odoo#88438 X-original-commit: d467881f66b11021005005584854f30059971b6c Signed-off-by: Quentin Smetz (qsm) --- odoo/addons/test_new_api/tests/test_onchange.py | 5 +++-- odoo/models.py | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/odoo/addons/test_new_api/tests/test_onchange.py b/odoo/addons/test_new_api/tests/test_onchange.py index 73a8cc4a204..472ff6de6d0 100644 --- a/odoo/addons/test_new_api/tests/test_onchange.py +++ b/odoo/addons/test_new_api/tests/test_onchange.py @@ -599,10 +599,11 @@ class TestOnChange(SavepointCaseWithUserDemo): form = common.Form(self.env['test_new_api.multi.tag']) self.assertEqual(form.name, False) - self.assertEqual(form.display_name, False) + self.assertEqual(form.display_name, "") record = form.save() - self.assertEqual(record.display_name, False) + self.assertEqual(record.name, False) + self.assertEqual(record.display_name, "") self.assertEqual(record.name_get(), [(record.id, "")]) diff --git a/odoo/models.py b/odoo/models.py index bf49483c66e..12d01dc4206 100644 --- a/odoo/models.py +++ b/odoo/models.py @@ -1835,7 +1835,7 @@ class BaseModel(metaclass=MetaModel): """ names = dict(self.name_get()) for record in self: - record.display_name = names.get(record.id) or False + record.display_name = names.get(record.id) def name_get(self): """Returns a textual representation for the records in ``self``, with