From 8526bf26b30be8063c1a072e8b34c46c2a3420fe Mon Sep 17 00:00:00 2001
From: Christophe Matthieu <chm@openerp.com>
Date: Wed, 31 Oct 2012 11:56:04 +0100
Subject: [PATCH] [IMP] view form: no question to complete informations in
 many2many_tag_email widget

bzr revid: chm@openerp.com-20121031105604-952pxf2rhlvupsx1
---
 addons/web/static/src/js/view_form.js | 45 +++++++++++++--------------
 1 file changed, 22 insertions(+), 23 deletions(-)

diff --git a/addons/web/static/src/js/view_form.js b/addons/web/static/src/js/view_form.js
index a6fcd2c46cb..575e22751af 100644
--- a/addons/web/static/src/js/view_form.js
+++ b/addons/web/static/src/js/view_form.js
@@ -3963,31 +3963,30 @@ instance.web.form.FieldMany2ManyTags = instance.web.form.AbstractField.extend(in
  */
 instance.web.form.FieldMany2ManyTagsEmail = instance.web.form.FieldMany2ManyTags.extend({
     add_id: function(id) {
-        this._super.apply(this, arguments);
-
         var self = this;
-        new instance.web.Model('res.partner').call("read", [id, ["email"]], {context: this.build_context()}).pipe(function (dict) {
-            if (!dict.email) {
-                if (! confirm(_t("This partner don't have email.\nDo you want to complete the partner's informations?"))) { return false; }
-                self.on_complete_informations(dict);
-            }
-        });
+        new instance.web.Model('res.partner').call("read", [id, ["email", "notification_email_send"]], {context: this.build_context()})
+            .pipe(function (dict) {
+                if (!dict.email && (dict.notification_email_send == 'all' || dict.notification_email_send == 'comment')) {
+                    var pop = new instance.web.form.FormOpenPopup(self);
+                    pop.show_element(
+                        'res.partner',
+                        dict.id,
+                        self.build_context(),
+                        {
+                            title: _t("Complete partner's informations"),
+                        }
+                    );
+                    pop.on('write_completed', self, function () {
+                        self._add_id(dict.id)
+                    });
+                } else {
+                    self._add_id(dict.id);
+                }
+            });
     },
-
-    on_complete_informations: function (dict) {
-        var self = this;
-
-        var pop = new instance.web.form.FormOpenPopup(self);
-        pop.show_element(
-            'res.partner',
-            dict.id,
-            self.build_context(),
-            {
-                title: _t("Complete partner's informations"),
-            }
-        );
-    },
-
+    _add_id: function (id) {
+        this.set({'value': _.uniq(this.get('value').concat([id]))});
+    }
 });
 
 /**