From 851878e36ae0a4bdb57d23dbc8725a1950cd84bc Mon Sep 17 00:00:00 2001 From: "Tiffany Chang (tic)" Date: Mon, 30 Oct 2023 14:16:45 +0100 Subject: [PATCH] [FIX] mrp,stock: correctly handle client action behaviors Fixes 2 use cases: - barcode redirect after picking is validated (should return to menu instead of refreshing the validated picking). Issue was due to missing renaming of "on_close" to "onClose" after refactor occured - ensure the auto-print action during MO validation always has a context because the "Shop Floor/MES" expects any returned actions from validation to always have a context to add the extra context parameter of "skip_redirection" to it closes odoo/odoo#140352 Signed-off-by: Arnold Moyaux (arm) --- addons/mrp/models/mrp_production.py | 1 + addons/stock/static/src/client_actions/multi_print.js | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/addons/mrp/models/mrp_production.py b/addons/mrp/models/mrp_production.py index c9a9b7e6d58..e7e3f328a5d 100644 --- a/addons/mrp/models/mrp_production.py +++ b/addons/mrp/models/mrp_production.py @@ -1982,6 +1982,7 @@ class MrpProduction(models.Model): return { 'type': 'ir.actions.client', 'tag': 'do_multi_print', + 'context': {}, 'params': { 'reports': report_actions, } diff --git a/addons/stock/static/src/client_actions/multi_print.js b/addons/stock/static/src/client_actions/multi_print.js index 586f625f275..2c764378f68 100644 --- a/addons/stock/static/src/client_actions/multi_print.js +++ b/addons/stock/static/src/client_actions/multi_print.js @@ -27,9 +27,9 @@ async function doMultiPrint(env, action) { } if (action.params.anotherAction) { return env.services.action.doAction(action.params.anotherAction); - } else if (action.params.on_close) { + } else if (action.params.onClose) { // handle special cases such as barcode - action.params.on_close() + action.params.onClose() } else { return env.services.action.doAction("reload_context"); }