From 84ad30338d01c8d5ce445dfa9389df137d829b12 Mon Sep 17 00:00:00 2001
From: Xavier Morel <xmo@odoo.com>
Date: Mon, 15 May 2023 07:44:20 +0000
Subject: [PATCH] [FIX] hr_contract: demo data to fix uninstall

On install, `hr_work_entry_contract` only associates work entries to
contacts which are open or closed.

However during its execution (?) `hr_work_entry_contract` generates
entries associated with `Mitchell Admin Contract`, which is a draft
contract. As a result, when uninstalling then reinstalling
`hr_work_entry_contract` it is not able to re-associate the entries to
the contract, and thus can't reinstate the `required=True` on
`HrWorkEntry.contract_id` either, which is a "reinstallation failure"
on the CI.

A simple solution is to create the contract closed, though it would
also be a good idea to not be able to create work entries associated
with a draft contract either, maybe?

X-original-commit: 6b7f3f6ec40eb819dd1d94a94722610a63d5697a
Part-of: odoo/odoo#121522
---
 addons/hr_contract/data/hr_contract_demo.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/addons/hr_contract/data/hr_contract_demo.xml b/addons/hr_contract/data/hr_contract_demo.xml
index 40d9ac3fdee..913538a28cc 100644
--- a/addons/hr_contract/data/hr_contract_demo.xml
+++ b/addons/hr_contract/data/hr_contract_demo.xml
@@ -15,7 +15,7 @@
         <field name="department_id" model="hr.department"
             eval="obj().env.ref('hr.employee_admin').department_id.id"/>
         <field eval="7540.0" name="wage"/>
-        <field name="state">draft</field>
+        <field name="state">close</field>
         <field name="kanban_state">normal</field>
         <field name="resource_calendar_id" ref="resource.resource_calendar_std_38h"/>
         <field name="hr_responsible_id" ref="base.user_admin"/>