From 84723d4278dae1cdabefa5d0ba86078dc9f46382 Mon Sep 17 00:00:00 2001 From: Raphael Collet Date: Wed, 12 Feb 2020 16:19:17 +0000 Subject: [PATCH] [IMP] core: add warning when removing field on upgrade The purpose is to force developers to explicitly manage the removal of field via migration scripts. closes odoo/odoo#45269 Related: odoo/upgrade#777 Signed-off-by: Raphael Collet (rco) --- odoo/addons/base/models/ir_model.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/odoo/addons/base/models/ir_model.py b/odoo/addons/base/models/ir_model.py index 87cd77d57f7..c127ed15a95 100644 --- a/odoo/addons/base/models/ir_model.py +++ b/odoo/addons/base/models/ir_model.py @@ -2018,6 +2018,12 @@ class IrModelData(models.Model): _logger.info('Deleting %s@%s (%s)', res_id, model, xmlid) record = self.env[model].browse(res_id) if record.exists(): + if record._name == 'ir.model.fields': + _logger.warning( + "Deleting field %s.%s (hint: fields should be" + " explicitly removed by an upgrade script)", + record.model, record.name, + ) record.unlink() else: bad_imd_ids.append(id)