From 841ebee16db305183c91e236a74472385b04ba6e Mon Sep 17 00:00:00 2001
From: Jeremy Kersten <jke@odoo.com>
Date: Thu, 23 Apr 2020 14:27:50 +0000
Subject: [PATCH] [IMP] website_blog: blog post, replace viewref by
 is_view_enable

is_view_enable is cached

task-2211013

Co-authored-by: Romain Derie <rde@odoo.com>
Co-authored-by: Jeremy Kersten <jke@odoo.com>
---
 addons/website_blog/tests/test_performance.py     |  4 ++--
 .../website_blog/views/website_blog_templates.xml | 15 +++++++--------
 2 files changed, 9 insertions(+), 10 deletions(-)

diff --git a/addons/website_blog/tests/test_performance.py b/addons/website_blog/tests/test_performance.py
index 0f0443e9188..36fcb2e8ee6 100644
--- a/addons/website_blog/tests/test_performance.py
+++ b/addons/website_blog/tests/test_performance.py
@@ -20,7 +20,7 @@ class TestBlogPerformance(UtilPerf):
             blog_post.tag_ids += blog_tags
             blog_tags = blog_tags[:-1]
         self.assertEqual(self._get_url_hot_query('/blog'), 26)
-        self.assertEqual(self._get_url_hot_query(blog_post[0].website_url), 47)
+        self.assertEqual(self._get_url_hot_query(blog_post[0].website_url), 33)
 
     def test_30_perf_sql_blog_bigger_data_scaling(self):
         BlogPost = self.env['blog.post']
@@ -33,4 +33,4 @@ class TestBlogPerformance(UtilPerf):
             blog_post.write({'tag_ids': [[6, 0, random.choices(blog_tags.ids, k=random.randint(0, len(blog_tags)))]]})
 
         self.assertEqual(self._get_url_hot_query('/blog'), 26)
-        self.assertEqual(self._get_url_hot_query(blog_post[0].website_url), 47)
+        self.assertEqual(self._get_url_hot_query(blog_post[0].website_url), 33)
diff --git a/addons/website_blog/views/website_blog_templates.xml b/addons/website_blog/views/website_blog_templates.xml
index f803b326e3e..8c6a5c0143b 100644
--- a/addons/website_blog/views/website_blog_templates.xml
+++ b/addons/website_blog/views/website_blog_templates.xml
@@ -217,13 +217,12 @@ list of filtered posts (by date or tag).
     <t t-call="website_blog.index">
 
         <!-- Check for active options: the stored value may be used in sub-templates too  -->
-        <t t-set="opt_blog_post_readable" t-value="request.website.viewref('website_blog.opt_blog_post_readable').active"/>
-        <t t-set="opt_blog_post_sidebar" t-value="request.website.viewref('website_blog.opt_blog_post_sidebar').active"/>
-        <t t-set="opt_blog_post_regular_cover" t-value="request.website.viewref('website_blog.opt_blog_post_regular_cover').active"/>
-        <t t-set="opt_blog_post_breadcrumb" t-value="request.website.viewref('website_blog.opt_blog_post_breadcrumb').active"/>
-        <t t-set="opt_blog_post_select_to_tweet" t-value="request.website.viewref('website_blog.opt_blog_post_select_to_tweet').active"/>
-        <t t-set="opt_blog_post_comment" t-value="request.website.viewref('website_blog.opt_blog_post_comment').active"/>
-        <t t-set="opt_blog_post_select_to_comment" t-value="request.website.viewref('website_blog.opt_blog_post_select_to_comment').active"/>
+        <t t-set="opt_blog_post_readable" t-value="is_view_active('website_blog.opt_blog_post_readable')"/>
+        <t t-set="opt_blog_post_sidebar" t-value="is_view_active('website_blog.opt_blog_post_sidebar')"/>
+        <t t-set="opt_blog_post_regular_cover" t-value="is_view_active('website_blog.opt_blog_post_regular_cover')"/>
+        <t t-set="opt_blog_post_breadcrumb" t-value="is_view_active('website_blog.opt_blog_post_breadcrumb')"/>
+        <t t-set="opt_blog_post_select_to_tweet" t-value="is_view_active('website_blog.opt_blog_post_select_to_tweet')"/>
+        <t t-set="opt_blog_post_select_to_comment" t-value="is_view_active('website_blog.opt_blog_post_select_to_comment')"/>
 
         <section id="o_wblog_post_top">
             <div id="title" class="blog_header" t-ignore="True">
@@ -346,7 +345,7 @@ list of filtered posts (by date or tag).
                                 <t t-else="">Comment</t>
                             </a>
                         </span>
-                        <span t-elif="opt_blog_post_comment">| No comments yet</span>
+                        <span t-elif="is_view_active('website_blog.opt_blog_post_comment')">| No comments yet</span>
                     </div>
                 </div>