From 83d26ad397187eb07581eadacacbb0b0336761df Mon Sep 17 00:00:00 2001 From: "Ujjvala Collins (OpenERP)" Date: Fri, 18 Feb 2011 15:35:46 +0530 Subject: [PATCH] [REF] sync_goolge_contact: Refactored code to stop creating multiple address entries. bzr revid: uco@tinyerp.com-20110218100546-zgjv4gk7nj6d45xi --- .../wizard/google_contact_import.py | 21 ++++++++----------- 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/addons/sync_google_contact/wizard/google_contact_import.py b/addons/sync_google_contact/wizard/google_contact_import.py index d5d69d88179..77c3c159029 100644 --- a/addons/sync_google_contact/wizard/google_contact_import.py +++ b/addons/sync_google_contact/wizard/google_contact_import.py @@ -134,19 +134,16 @@ class synchronize_google_contact(osv.osv_memory): partner_ids.append(partner_id[0]) addresses.append(addresss_obj.create(cr, uid, data, context=context)) contact_ids = addresss_obj.search(cr, uid, [('email','ilike',emails)]) - if not contact_ids: - if obj.group_name and entry.group_membership_info: - for grp in entry.group_membership_info: - if grp.href == obj.group_name: - if obj.create_partner: - partner_id, data = self.create_partner(cr, uid, ids, data, context=context) - partner_ids.append(partner_id[0]) - addresses.append(addresss_obj.create(cr, uid, data, context=context)) - else: - if obj.group_name == 'all': - addresses.append(addresss_obj.create(cr, uid, data, context=context)) + if obj.group_name and entry.group_membership_info and not contact_ids: + for grp in entry.group_membership_info: + if grp.href == obj.group_name: + if obj.create_partner: + partner_id, data = self.create_partner(cr, uid, ids, data, context=context) + partner_ids.append(partner_id[0]) + addresses.append(addresss_obj.create(cr, uid, data, context=context)) else: - addresss_obj.write(cr, uid, contact_ids, data, context=context) + if obj.group_name == 'all' and not contact_ids: + addresses.append(addresss_obj.create(cr, uid, data, context=context)) if not contact: break next = contact.GetNextLink()