From 8120fca14f1d97749a69722454da60946f58eb43 Mon Sep 17 00:00:00 2001
From: "Chrysanthe (chgo)" <chgo@odoo.com>
Date: Thu, 3 Aug 2023 12:42:31 +0000
Subject: [PATCH] [FIX] account, kanban_dashboard: fix favorite alignment
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Commit[1] introduced some changes in order to fix a layout issue in the
accounting dashboard but these changes were applied in a way that affects
a lot of modules and files that should not be modified.

In fact, by removing the padding inside the `kanban_dashboard.scss`
commit[1] is actually removing the padding in every place where
the boolean_favorite widget is used.

There is also a change applied in the Bootstrap library files, which
should remain untouched.

=== AFTER ===

We revert the changes applied by commit[1] and also fix the layout issue
in the accounting dashboard that it aimed to fix.

commit[1]: d4ba0c1

task-3453799
part of task-3326263

closes odoo/odoo#132134

X-original-commit: f78571cec0a5debf78c5dd1859c78b13d33df1ab
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
---
 addons/account/views/account_journal_dashboard_view.xml  | 2 +-
 addons/web/static/lib/bootstrap/scss/_buttons.scss       | 1 -
 addons/web/static/src/views/kanban/kanban_dashboard.scss | 1 +
 3 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/addons/account/views/account_journal_dashboard_view.xml b/addons/account/views/account_journal_dashboard_view.xml
index c0027892cbb..4898cfc2a63 100644
--- a/addons/account/views/account_journal_dashboard_view.xml
+++ b/addons/account/views/account_journal_dashboard_view.xml
@@ -206,7 +206,7 @@
                             </div>
 
                             <div groups="account.group_account_manager" class="row o_kanban_card_manage_settings">
-                                <div class="col-6 position-relative">
+                                <div class="col-6 position-relative mt-n2">
                                     <field name="show_on_dashboard" widget="boolean_favorite"/>
                                 </div>
                                 <div class="col-6 text-end">
diff --git a/addons/web/static/lib/bootstrap/scss/_buttons.scss b/addons/web/static/lib/bootstrap/scss/_buttons.scss
index 72d09decb35..ee4287c9201 100644
--- a/addons/web/static/lib/bootstrap/scss/_buttons.scss
+++ b/addons/web/static/lib/bootstrap/scss/_buttons.scss
@@ -76,7 +76,6 @@
 
 // Make a button look and behave like a link
 .btn-link {
-  padding: 0;
   font-weight: $font-weight-normal;
   color: $btn-link-color;
   text-decoration: $link-decoration;
diff --git a/addons/web/static/src/views/kanban/kanban_dashboard.scss b/addons/web/static/src/views/kanban/kanban_dashboard.scss
index b9ae0905cba..3810f1808f4 100644
--- a/addons/web/static/src/views/kanban/kanban_dashboard.scss
+++ b/addons/web/static/src/views/kanban/kanban_dashboard.scss
@@ -191,6 +191,7 @@
             $top: 3px,
             $left: calc(var(--KanbanRecord-padding-h) - #{$o-horizontal-padding})
         );
+        padding: $o-kanban-record-margin;
     }
 }