From e3775db303b180c42ba0ca7709ba64d315b9dfe0 Mon Sep 17 00:00:00 2001 From: Xavier ALT Date: Fri, 1 Jun 2012 16:33:28 +0200 Subject: [PATCH 1/2] [FIX] account_payment: on payment line import, use 'debit' lines from voucher onchanger - otherwise created voucher is empty bzr revid: xal@openerp.com-20120601143328-c1kpk1c2adkzmv0y --- .../wizard/account_payment_populate_statement.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/addons/account_payment/wizard/account_payment_populate_statement.py b/addons/account_payment/wizard/account_payment_populate_statement.py index 6f2d9d02dbc..cedfe55a2e5 100644 --- a/addons/account_payment/wizard/account_payment_populate_statement.py +++ b/addons/account_payment/wizard/account_payment_populate_statement.py @@ -95,8 +95,8 @@ class account_payment_populate_statement(osv.osv_memory): } voucher_id = voucher_obj.create(cr, uid, voucher_res, context=context) voucher_line_dict = False - if result['value']['line_ids']: - for line_dict in result['value']['line_ids']: + if result['value']['line_dr_ids']: + for line_dict in result['value']['line_dr_ids']: move_line = move_line_obj.browse(cr, uid, line_dict['move_line_id'], context) if line.move_line_id.move_id.id == move_line.move_id.id: voucher_line_dict = line_dict @@ -120,4 +120,4 @@ class account_payment_populate_statement(osv.osv_memory): account_payment_populate_statement() -# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4: \ No newline at end of file +# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4: From 62360913cd90a8b5fc074ff9691fc3c57e939ab6 Mon Sep 17 00:00:00 2001 From: Xavier ALT Date: Fri, 1 Jun 2012 16:49:35 +0200 Subject: [PATCH 2/2] [IMP] account_payment: add comment why only checking on 'debit' when creating voucher from 'import payment line wizard' bzr revid: xal@openerp.com-20120601144935-zya10gihz0c6w1qn --- .../wizard/account_payment_populate_statement.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/addons/account_payment/wizard/account_payment_populate_statement.py b/addons/account_payment/wizard/account_payment_populate_statement.py index cedfe55a2e5..b74ae87a685 100644 --- a/addons/account_payment/wizard/account_payment_populate_statement.py +++ b/addons/account_payment/wizard/account_payment_populate_statement.py @@ -95,6 +95,9 @@ class account_payment_populate_statement(osv.osv_memory): } voucher_id = voucher_obj.create(cr, uid, voucher_res, context=context) voucher_line_dict = False + + # NOTE: we only check for lines on 'debit' as Payment Order only allow user + # to choose account.move.line with credit > 0, i.e payment will be on 'debit' if result['value']['line_dr_ids']: for line_dict in result['value']['line_dr_ids']: move_line = move_line_obj.browse(cr, uid, line_dict['move_line_id'], context)