pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[IMP] project: improve create task shortcuts

Browse Source 
Before this commit:
In 16.2, we have implemented a nice tool to set various fields at the creation of a task from
the Kanban quick create using shortcuts.
This implementation is simple (only a few lines of code), but is not very flexible.
Indeed, shortcuts need to be in a specific order and at a specific place for them to work.
As a consequence, it is very easy for the user to fail in the creation of their tasks using shortcuts.
This task aims at making this feature more robust and complex so that it works in more cases.

In this commit:
It should be possible for the #tag, 23h, @demo, ! shortcuts to be put in whatever order, as long as they are at the end of the name

task-3349154

closes odoo/odoo#124155

Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
This commit is contained in:
Raouf
2023-06-22 09:50:29 +02:00
parent 1214542413
commit 7fe8dc7720
4 changed files with 21 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/project/tests/test_project_task_quick_create.py
+7 -5
View File
@@ -24,8 +24,11 @@ class TestProjectTaskQuickCreate(TestProjectCommon):
def test_create_task_with_valid_expressions(self):
# dict format = {display name: (expected name, expected tags count, expected users count, expected priority, expected planned hours)}
valid_expressions = {
'task A 30H 2.5h #Tag1 #tag2 #tag3 @Armande @Bast @raouf1 @raouf2 !': ('task A 30H 2.5h', 3, 4, "1", 0),
'task A 30H 2.5h #Tag1 #tag2 @Armande @Bast @raouf1 @raouf2 !': ('task A 30H 2.5h', 2, 4, "1", 0),
'task A 30H 2.5h #Tag1 #tag2 #tag3 @Armande @Bast @raouf1 ! @raouf2': ('task A 30H 2.5h', 3, 4, "1", 0),
'task A ! 30H 2.5h #Tag1 #tag2 #tag3 @Armande @Bast ! @raouf1 #tag4': ('task A 30H 2.5h', 4, 3, "1", 0),
'task A': ('task A', 0, 0, "0", 0),
'task A !': ('task A', 0, 0, "1", 0),
'task A 30H 2.5h #Tag1 #tag2 #tag3 @Armande @Bast @raouf1 @raouf2': ('task A 30H 2.5h', 3, 4, "0", 0),
'task A 30H 2.5h #Tag1 @Armande #tag3 @Bast @raouf1 #tag2 @raouf2 #tag4': ('task A 30H 2.5h', 4, 4, "0", 0),
'task A 30H #tag1 @raouf1 Nothing !': ('task A 30H #tag1 @raouf1 Nothing', 0, 0, '1', 0),
@@ -43,11 +46,10 @@ class TestProjectTaskQuickCreate(TestProjectCommon):
def test_create_task_with_invalid_expressions(self):
invalid_expressions = (
'task A 30H #tag1 @raouf1 @raouf2 !!',
'task A 30H #tag1 @raouf2 user',
'#tag1 #tag2 #tag3 @Armande @Bast @raouf1 @raouf2 !',
'@Armande @Bast @raouf1 @raouf2 !',
'#tag1 #tag2 #tag3 @Armande @Bast @raouf1 @raouf2',
'@Armande @Bast @raouf1 @raouf2',
'!',
'task A!'
)
for expression in invalid_expressions: