From 7fb4d8f91956f764c5fc194ddf5ebc077d75a535 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thibault=20Delavall=C3=A9e?= Date: Thu, 18 Aug 2022 11:15:23 +0000 Subject: [PATCH] [FIX] mail: remove unnecessary getattr We can access fields directly on a record, no need to have a getattr. closes odoo/odoo#98287 Signed-off-by: Thibault Delavallee (tde) --- addons/mail/wizard/mail_compose_message.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/addons/mail/wizard/mail_compose_message.py b/addons/mail/wizard/mail_compose_message.py index 01ab742ced5..4229b0f0c0c 100644 --- a/addons/mail/wizard/mail_compose_message.py +++ b/addons/mail/wizard/mail_compose_message.py @@ -543,12 +543,12 @@ class MailComposer(models.TransientModel): if template_id and composition_mode == 'mass_mail': template = self.env['mail.template'].browse(template_id) values = dict( - (field, getattr(template, field)) + (field, template[field]) for field in ['subject', 'body_html', 'email_from', 'reply_to', 'mail_server_id'] - if getattr(template, field) + if template[field] ) if template.attachment_ids: values['attachment_ids'] = [att.id for att in template.attachment_ids]