From 7fa1525921084cb02cdb0313f6fc166d299c63ab Mon Sep 17 00:00:00 2001
From: Kishan Gajjar <kig@odoo.com>
Date: Wed, 11 Jul 2018 13:14:39 +0530
Subject: [PATCH] [FIX] web: correctly render "font awesome" icons on buttons

Revision on https://github.com/odoo/odoo/commit/9de1bc0

From the commit above, the style of some field binary images are broken.
This is due to changes from `<span>` to `<button>`. The style has been
altered by the default browser's style, which does the following on
Google Chrome:

```
    border-color: white;
    border: 1px solid;
    padding: 1px 7px 2px;
```

Most browsers set a border and some padding on buttons. This commit fixes
the style specifically for "font awesome" icons on buttons, by removing
the border and by overwriting the padding.

Tested browsers:

  - Google Chrome 67
  - Mozilla Firefox 61
  - Safari 11

Task-ID 1864027

Closes #25691
---
 addons/web/static/src/scss/fields.scss | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/addons/web/static/src/scss/fields.scss b/addons/web/static/src/scss/fields.scss
index 6683a8cba24..370fdc036b3 100644
--- a/addons/web/static/src/scss/fields.scss
+++ b/addons/web/static/src/scss/fields.scss
@@ -355,6 +355,11 @@
             opacity: 0;
             transition: opacity ease 400ms;
 
+            > button.fa {
+                border: none;
+                background-color: transparent;
+            }
+
             > .fa {
                 margin: 5px;
                 cursor: pointer;