From 7f5f2963966f5a3bcfeb4bede0f9d956fff6e831 Mon Sep 17 00:00:00 2001 From: Xavier Morel Date: Mon, 25 Mar 2024 14:33:04 +0100 Subject: [PATCH] [REM] base: broken method `Partner._email_send` The underlying `odoo.tools.email_send` was removed in 82de620424e22f9ca7cb9768db638c3a2b4f9318 (merged in 14.5) but this callsite was missed, this method has been broken ever since. I really want to remove this method directly, but technically it's an expensive no-op if called on a recordset of partners without emails set (or an empty recordset), so instead make it trigger a warning & remove in master. closes odoo/odoo#159177 X-original-commit: 457a4be9d6bb1e15b996a5a14468f9b0d88e0b0f Signed-off-by: Xavier Morel (xmo) --- odoo/addons/base/models/res_partner.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/odoo/addons/base/models/res_partner.py b/odoo/addons/base/models/res_partner.py index 91de78f6d34..a6411bd36f2 100644 --- a/odoo/addons/base/models/res_partner.py +++ b/odoo/addons/base/models/res_partner.py @@ -8,6 +8,7 @@ import hashlib import pytz import threading import re +import warnings import requests from collections import defaultdict @@ -924,8 +925,7 @@ class Partner(models.Model): return base64.b64encode(res.content) def _email_send(self, email_from, subject, body, on_error=None): - for partner in self.filtered('email'): - tools.email_send(email_from, [partner.email], subject, body, on_error) + warnings.warn("Partner._email_send has not done anything but raise errors since 15.0", stacklevel=2, category=DeprecationWarning) return True def address_get(self, adr_pref=None):