From 7e8b8a3ce8543da8db99fdc267979a5a38e8e100 Mon Sep 17 00:00:00 2001 From: Xavier Morel Date: Thu, 15 Sep 2011 12:40:53 +0200 Subject: [PATCH] [IMP] ensure file is correctly closed even if file.write() blows up (also -3+2) bzr revid: xmo@openerp.com-20110915104053-fklc9ae853eytods --- openerp/addons/base/module/module.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/openerp/addons/base/module/module.py b/openerp/addons/base/module/module.py index 91801b0b1c5..88b1bc009bb 100644 --- a/openerp/addons/base/module/module.py +++ b/openerp/addons/base/module/module.py @@ -440,9 +440,8 @@ class module(osv.osv): zip_content = urllib.urlopen(mod.url).read() fname = addons.get_module_path(str(mod.name)+'.zip', downloaded=True) try: - fp = file(fname, 'wb') - fp.write(zip_content) - fp.close() + with open(fname, 'wb') as fp: + fp.write(zip_content) except Exception: self.__logger.exception('Error when trying to create module ' 'file %s', fname)