From 7e1304c137341ce573306be1730bc283ac96fe06 Mon Sep 17 00:00:00 2001
From: Bruno Boi <boi@odoo.com>
Date: Thu, 29 Sep 2022 12:07:12 +0000
Subject: [PATCH] [FIX] web: color edition of many2many_tags_field

Before this commit
Can display the color list picker event if no color_field has been set.
This could lead to a traceback if a color is selected.

After this commit
The field does not allow to show the color list without a color_field.

closes odoo/odoo#101679

X-original-commit: 160ba4b4edfde052d9881a23294ceafc0ceec278
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
---
 .../many2many_tags/many2many_tags_field.js     |  4 +++-
 .../views/fields/many2many_tags_field_tests.js | 18 +++++++++++++++++-
 2 files changed, 20 insertions(+), 2 deletions(-)

diff --git a/addons/web/static/src/views/fields/many2many_tags/many2many_tags_field.js b/addons/web/static/src/views/fields/many2many_tags/many2many_tags_field.js
index ff20dc45054..ad94be50ef3 100644
--- a/addons/web/static/src/views/fields/many2many_tags/many2many_tags_field.js
+++ b/addons/web/static/src/views/fields/many2many_tags/many2many_tags_field.js
@@ -347,9 +347,11 @@ Many2ManyTagsFieldColorEditable.defaultProps = {
 Many2ManyTagsFieldColorEditable.extractProps = (params) => {
     const props = Many2ManyTagsField.extractProps(params);
     const attrs = params.attrs;
+    const noEditColor = Boolean(attrs.options.no_edit_color);
+    const hasColorField = Boolean(attrs.options.color_field);
     return {
         ...props,
-        canEditColor: !attrs.options.no_edit_color,
+        canEditColor: !noEditColor && hasColorField,
     };
 };
 
diff --git a/addons/web/static/tests/views/fields/many2many_tags_field_tests.js b/addons/web/static/tests/views/fields/many2many_tags_field_tests.js
index 32ace21498f..2a12379b52d 100644
--- a/addons/web/static/tests/views/fields/many2many_tags_field_tests.js
+++ b/addons/web/static/tests/views/fields/many2many_tags_field_tests.js
@@ -108,7 +108,7 @@ QUnit.module("Fields", (hooks) => {
     QUnit.module("Many2ManyTagsField");
 
     QUnit.test("Many2ManyTagsField with and without color", async function (assert) {
-        assert.expect(4);
+        assert.expect(12);
 
         serverData.models.partner.fields.partner_ids = {
             string: "Partner",
@@ -142,8 +142,18 @@ QUnit.module("Fields", (hooks) => {
             },
         });
 
+        // Add a tag to first field
+        assert.containsNone(target, "[name=partner_ids] .o_tag");
         await selectDropdownItem(target, "partner_ids", "first record");
+        assert.containsOnce(target, "[name=partner_ids] .o_tag");
 
+        // Show the color list
+        assert.containsNone(target, ".o_colorlist");
+        await click(target, "[name=partner_ids] .o_tag");
+        assert.containsOnce(target, ".o_colorlist");
+
+        // Add a tag to second field
+        assert.containsNone(target, "[name=timmy] .o_tag");
         await clickDropdown(target, "timmy");
         const autocomplete = target.querySelector("[name='timmy'] .o-autocomplete.dropdown");
         assert.strictEqual(
@@ -152,12 +162,18 @@ QUnit.module("Fields", (hooks) => {
             "autocomplete dropdown should have 3 entries (2 values + 'Search and Edit...')"
         );
         await clickOpenedDropdownItem(target, "timmy", "gold");
+        assert.containsOnce(target, "[name=timmy] .o_tag");
         assert.deepEqual(
             getNodesTextContent(
                 target.querySelectorAll(`.o_field_many2many_tags[name="timmy"] .badge`)
             ),
             ["gold"]
         );
+
+        // Show the color list
+        assert.containsNone(target, ".o_colorlist");
+        await click(target, "[name=timmy] .o_tag");
+        assert.containsNone(target, ".o_colorlist");
     });
 
     QUnit.test("Many2ManyTagsField with color: rendering and edition", async function (assert) {