From 7ccc01183305588dc752b84658a162fa8f509cdd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Geelen=20=28sge=29?= Date: Tue, 6 Apr 2021 11:54:36 +0000 Subject: [PATCH] [FIX] web_editor: fix traceback when selection is null closes odoo/odoo#68827 Signed-off-by: David Monjoie (dmo) --- addons/web_editor/static/src/js/editor/snippets.editor.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/addons/web_editor/static/src/js/editor/snippets.editor.js b/addons/web_editor/static/src/js/editor/snippets.editor.js index fda404ab8b7..cdfdf1b4908 100644 --- a/addons/web_editor/static/src/js/editor/snippets.editor.js +++ b/addons/web_editor/static/src/js/editor/snippets.editor.js @@ -2999,7 +2999,7 @@ var SnippetsMenu = Widget.extend({ _checkEditorToolbarVisibility: function (e) { const $toolbarContainer = $('#o_we_editor_toolbar_container'); const docSelection = document.getSelection(); - const $currentSelectionTarget = docSelection.rangeCount > 0 ? $(docSelection.getRangeAt(0).commonAncestorContainer) : $(); + const $currentSelectionTarget = docSelection && docSelection.rangeCount > 0 ? $(docSelection.getRangeAt(0).commonAncestorContainer) : $(); // Do not toggle visibility if the target is inside the toolbar ( eg. during link edition). if ($currentSelectionTarget.parents('#toolbar').length || (e && $(e.target).parents('#toolbar').length) @@ -3008,7 +3008,7 @@ var SnippetsMenu = Widget.extend({ } const selection = this.options.wysiwyg.odooEditor.document.getSelection(); - const range = selection.rangeCount && selection.getRangeAt(0); + const range = selection && selection.rangeCount && selection.getRangeAt(0); if (!range || !$(range.commonAncestorContainer).parents('#wrapwrap').length || $(range.commonAncestorContainer).parent('[data-oe-model]:not([data-oe-type="html"]):not([data-oe-field="arch"])').length