From 7b61eefc0e3af61fc49231f817cf8fa442da7b5d Mon Sep 17 00:00:00 2001 From: Joseph Caburnay Date: Thu, 10 Nov 2022 10:33:26 +0000 Subject: [PATCH] [FIX] web: should keep background of folded column **Issue:** When moving a record in a kanban view from one column to another, it is possible to keep holding the record, hover it in one column for a moment, then move again to another column then eventually drop the record. Doing this where a folded column is the intermediate column results to visual issue, such that the darker highlight of a folded column is lost. The desired behavior is to keep the background color of a folded column. **Solution:** When moving a record, the hovered column is highlighted, and right after leaving the column, we remove the highlight. And we are doing this without exempting the folded column, thus, its darker highlight is lost during the record-moving-hovering process. Instead of adding/removing .bg-100 during unhover/hover on each kanban column to make sure of the "greenish" tint of the column when hovered, we just make background of the .o_kanban_hover to be important. closes odoo/odoo#105689 X-original-commit: fdd7f017c73718c9582256dde3124dd2655aeb01 Signed-off-by: Julien Mougenot (jum) Signed-off-by: Joseph Caburnay (jcb) --- addons/web/static/src/views/kanban/kanban_controller.scss | 2 +- addons/web/static/src/views/kanban/kanban_renderer.js | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/addons/web/static/src/views/kanban/kanban_controller.scss b/addons/web/static/src/views/kanban/kanban_controller.scss index 06514da7ef6..f8deec0606a 100644 --- a/addons/web/static/src/views/kanban/kanban_controller.scss +++ b/addons/web/static/src/views/kanban/kanban_controller.scss @@ -520,7 +520,7 @@ } } &.o_kanban_hover { - background-color: var(--KanbanColumn__highlight-background); + background-color: var(--KanbanColumn__highlight-background) !important; box-shadow: -1px 0px 0px 0px var(--KanbanColumn__highlight-border) inset, 1px 0px 0px 0px var(--KanbanColumn__highlight-border) inset; } diff --git a/addons/web/static/src/views/kanban/kanban_renderer.js b/addons/web/static/src/views/kanban/kanban_renderer.js index b7da556def6..17eb156d2bd 100644 --- a/addons/web/static/src/views/kanban/kanban_renderer.js +++ b/addons/web/static/src/views/kanban/kanban_renderer.js @@ -512,7 +512,6 @@ export class KanbanRenderer extends Component { */ sortRecordGroupEnter({ group }) { group.classList.add("o_kanban_hover"); - group.classList.remove("bg-100"); } /** @@ -521,7 +520,6 @@ export class KanbanRenderer extends Component { */ sortRecordGroupLeave({ group }) { group.classList.remove("o_kanban_hover"); - group.classList.add("bg-100"); } /**