From 7a9eba403a88846e1fe68bcb6111da3a4b2cae5a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thibault=20Delavall=C3=A9e?= Date: Fri, 19 Mar 2021 13:39:06 +0000 Subject: [PATCH] [FIX] event: do not autocommit when running event mail schedulers in test mode Otherwise it creates a lot of issues in your tests and database. Always avoid that kind of error-prone statements in testing mode. Related to Task ID-2414658 COM PR odoo/odoo#68158 X-original-commit: 3ad9126375e74071fec47f402f1fc63f98b755b6 --- addons/event/models/event_mail.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/addons/event/models/event_mail.py b/addons/event/models/event_mail.py index 58fc24af9ed..ee4c1094a47 100644 --- a/addons/event/models/event_mail.py +++ b/addons/event/models/event_mail.py @@ -1,6 +1,10 @@ # -*- coding: utf-8 -*- # Part of Odoo. See LICENSE file for full copyright and licensing details. +import logging +import random +import threading + from datetime import datetime from dateutil.relativedelta import relativedelta @@ -8,8 +12,6 @@ from odoo import api, fields, models, tools from odoo.tools import exception_to_unicode from odoo.tools.translate import _ -import random -import logging _logger = logging.getLogger(__name__) _INTERVALS = { @@ -176,7 +178,7 @@ You receive this email because you are: self.invalidate_cache() self._warn_template_error(scheduler, e) else: - if autocommit: + if autocommit and not getattr(threading.currentThread(), 'testing', False): self.env.cr.commit() return True