From 79a3fc20c5cb646d41e2c1c2e2ff11923e582265 Mon Sep 17 00:00:00 2001 From: xO-Tx Date: Wed, 28 Jun 2023 14:37:57 +0000 Subject: [PATCH] [FIX] web: restore HTML report CSS Steps to reproduce: - Open base runbot with no installations > Install Account > Check an invoice preview. - Install Website > Check invoice preview > It looks narrow and does not fill the available width. Starting from [1], the code that sets the `container-fluid` class on HTML web reports was replaced with the Owl version on the `ReportAction` [2] but since some reports are not using this system, the code was restored in a separate JS module on 16.0. Starting from `16.1` (exactly after [3]), the JS code in `web.report_assets_common` bundle was removed completely from the report template, and reports are only using CSS [4]. So instead of a separate JS module, a temporary script was added to the template to maintain the same legacy behavior when a report is in iframe until all reports are fully converted. [1]: https://github.com/odoo/odoo/commit/feef532b417828905ce09675043b55b2b3736e43 [2]: https://github.com/odoo/odoo/commit/feef532b417828905ce09675043b55b2b3736e43#diff-ed0708a6c1a18e945a7829b2f8b17df7a2fbe4ab83e27fe6140dba79465c2832R39-R43 [3]: https://github.com/odoo/odoo/pull/104794/commits/37f009772ccb6bc9ed5733374e104e39c1e11792#diff-d9b97c730b0213bde5b18ab515e1e94fdb0809b8f760440ef7ca70163263101fL29-L30 [4]: Even after completely removing the JS code from HTML reports, the `web.report_assets_common` bundle still contains some unused legacy report JS code on stock: https://github.com/odoo/odoo/blob/saas-16.1/addons/stock/__manifest__.py#L98-L100 Maybe this code should be removed if it is not used anymore. opw-3209231 closes odoo/odoo#126716 X-original-commit: 98d14a0b657efcfd365a4e7a28bef91f57758e6b Signed-off-by: Romain Derie (rde) Signed-off-by: Outagant Mehdi (mou) --- addons/web/views/report_templates.xml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/addons/web/views/report_templates.xml b/addons/web/views/report_templates.xml index f60077a334f..a7df246da9b 100644 --- a/addons/web/views/report_templates.xml +++ b/addons/web/views/report_templates.xml @@ -15,6 +15,16 @@ <t t-esc="title or 'Odoo Report'"/> + + +