From 79953490015f77fcd3dbc25f2ddb33c063edaf1a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alexandre=20K=C3=BChn?= Date: Tue, 18 Apr 2023 13:04:58 +0000 Subject: [PATCH] [FIX] mail: correct breadcrumb when open discuss from chat window MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Before this commit, when opening Discuss from chat window and then accessing the settings page of a channel, the breadcrumb showed "Unamed" as the name of the App instead of "Discuss". This happens because the client action was not named when expanding the chat window by opening Discuss app. closes odoo/odoo#118939 Signed-off-by: Sébastien Theys (seb) --- .../mail/static/src/web/chat_window/chat_window.js | 2 ++ addons/mail/static/tests/discuss/discuss_tests.js | 14 ++++++++++++++ 2 files changed, 16 insertions(+) diff --git a/addons/mail/static/src/web/chat_window/chat_window.js b/addons/mail/static/src/web/chat_window/chat_window.js index 700603c914e..aa2ef94e754 100644 --- a/addons/mail/static/src/web/chat_window/chat_window.js +++ b/addons/mail/static/src/web/chat_window/chat_window.js @@ -16,6 +16,7 @@ import { ChannelInvitation } from "@mail/discuss/channel_invitation"; import { isEventHandled } from "@mail/utils/misc"; import { ChannelSelector } from "@mail/discuss/channel_selector"; import { PinnedMessagesPanel } from "@mail/discuss/pinned_messages_panel"; +import { _t } from "@web/core/l10n/translation"; /** * @typedef {Object} Props @@ -159,6 +160,7 @@ export class ChatWindow extends Component { { type: "ir.actions.client", tag: "mail.action_discuss", + name: _t("Discuss"), }, { clearBreadcrumbs: true } ); diff --git a/addons/mail/static/tests/discuss/discuss_tests.js b/addons/mail/static/tests/discuss/discuss_tests.js index ce432ad63a8..b6a21ab1f34 100644 --- a/addons/mail/static/tests/discuss/discuss_tests.js +++ b/addons/mail/static/tests/discuss/discuss_tests.js @@ -1929,3 +1929,17 @@ QUnit.test("Member list and settings menu are exclusive", async (assert) => { assert.containsOnce($, ".o-mail-CallSettings"); assert.containsNone($, ".o-mail-ChannelMemberList"); }); + +QUnit.test( + "Correct breadcrumb when open discuss from chat window then see settings", + async (assert) => { + const pyEnv = await startServer(); + pyEnv["mail.channel"].create({ name: "General" }); + await start(); + await click(".o_main_navbar i[aria-label='Messages']"); + await click(".o-mail-NotificationItem:contains(General)"); + await click(".o-mail-ChatWindow [title='Open in Discuss']"); + await click(".o-mail-DiscussCategoryItem:contains(General) [title='Channel settings']"); + assert.strictEqual($(".breadcrumb").text(), "DiscussGeneral"); + } +);