From e9f4fc98cc98dab4ca1fdab2f6d9697485934beb Mon Sep 17 00:00:00 2001
From: Xavier Morel <xmo@openerp.com>
Date: Tue, 3 Apr 2012 16:15:53 +0200
Subject: [PATCH 1/2] [ADD] display unhelpful message when a list view search
 yields no result

bzr revid: xmo@openerp.com-20120403141553-hrv006vdkv70zyfu
---
 addons/web/static/src/css/base.css             |   9 +++++++++
 addons/web/static/src/css/base.sass            |  14 ++++++++++++++
 addons/web/static/src/img/empty-list-arrow.png | Bin 0 -> 2308 bytes
 addons/web/static/src/js/view_list.js          |  15 +++++++++++++++
 4 files changed, 38 insertions(+)
 create mode 100644 addons/web/static/src/img/empty-list-arrow.png

diff --git a/addons/web/static/src/css/base.css b/addons/web/static/src/css/base.css
index b0a2b7945b9..d4a1d743d35 100644
--- a/addons/web/static/src/css/base.css
+++ b/addons/web/static/src/css/base.css
@@ -344,3 +344,12 @@
   -webkit-box-shadow: none;
   -box-shadow: none;
 }
+.openerp2 .oe-listview .oe_listview_nocontent > img {
+  float: left;
+  margin-right: 1.5em;
+}
+.openerp2 .oe-listview .oe_listview_nocontent > div {
+  overflow: hidden;
+  font-size: 150%;
+  width: 60ex;
+}
diff --git a/addons/web/static/src/css/base.sass b/addons/web/static/src/css/base.sass
index c31f501c499..ecc45f5f538 100644
--- a/addons/web/static/src/css/base.sass
+++ b/addons/web/static/src/css/base.sass
@@ -337,6 +337,20 @@ $colour4: #8a89ba
                         @include box-shadow(none)
     // }}}
 
+
+    // ListView {{{
+    .oe-listview
+        .oe_listview_nocontent
+            > img
+                float: left
+                margin-right: 1.5em
+            > div
+                // don't encroach on my arrow
+                overflow: hidden
+                font-size: 150%
+                width: 60ex
+    // }}}
+
 .openerp
     // Transitional overrides for old styles {{{
     // }}}
diff --git a/addons/web/static/src/img/empty-list-arrow.png b/addons/web/static/src/img/empty-list-arrow.png
new file mode 100644
index 0000000000000000000000000000000000000000..b0b1372adfd3fc393ecc1dac3934c423822970cd
GIT binary patch
literal 2308
zcmV+f3H$bmP)<h;3K|Lk000e1NJLTq002+`002-31^@s6juG;$000QfNkl<Zc-rk;
zdx#Wu9B)f|Ns(kmFX)9m=#Qu{qS7oVdqR)|6$KelR8&ww*&i!~b?)rU&dl!K?df%B
z{?n1Ao!-sNp01sFsg+0}1tIhRdyp9lhVEnfe1ALNnwGoUyWh^9JMIKuX0CB}fAjf$
zAD{1I<^<PuBWXa|9)JkI2*3!yx`O{=5rC0I0EQ00zP`Sb=$JHYT`}`_(Rn;xm=*yz
z0b!sNW8mt}l_M@d9QLloA^;}@VEjZ+`v%jwVb|>X)YT08QE{zMm=*yzjy#>qO{b%(
zI}c{Mx03c9H98A){3#yqKb--N032OnY{IHxe`j=U0dQ71X*fr_-rMdfhO?Be=W<_8
zj{qD+a-Q}nrt_NceY#zQ=DCovmL8(x;bg|Xh=WW7;Q#!dE6lRP7`PA`cgO>*0&zVl
zW>;>57TRm70J;%?W6+jWT|J)*-v@DPq@u$gCQSQwHuVTV9}uaueWRY;EWlDthqccq
zRtZs=&cEQ#VimEr2atn@VpxUD3W~h!`$m-_`A0=}o?^e*)&Md9s%|~v(U#IU;EAZL
zX9cbK)i4Im3^T0>O!E>6dj<gc5&lg8G%kP;rZq{^PVgqQC4ih&AhN#IDFTPXfuo*O
zR5M@I*7U|XVWl;JL|skWaH*nON7Qt_hPKp|Vs^!6u4-6o+ZsUCa6ahl8S&AU$%s{^
zJUL-l_lA+yG)!BPy0w4+V9k?|l9{8=J9~(Thpl4MaEV?u?d|FA;d->Cen5f$R7~r|
zu;s~((H7HQoPiGm0Mg*G8K<h`d;hZZ(Ak_89+v<zU(05<&Lke^WgRuNMP3VWOoz!A
z%2%3oE9K938x|8j)O1`GqGg<G!xEL{XiFx473H}QU+@S-ie4r&7?$irs$2!1wVujS
zOqv6h5(Om?^M}G<%9GAGl4<82s;02tYX*R#if!6^ktd(Rv?kO5`pZqwjBkjyalxP|
z!g;c8FKKmJGb!4VH1f|1?KADa$zQPq1ZJ7&4EIl}{?$3K%osSQl>^Fz{hq2?ms8*%
z%^*ilIV?CJj@#Tc{%#aN;(<oz7T1LN(k4+=r+3Y67ir>JUPmYaT(pSG^!dl39mAj+
zAHlTx(Q*3(n%EEd80VWP8sl0cAnt>FPbnRKXBP^yBiOJ4zH_629t%h1&;d9RC$4GM
zdBg{~8Y9C2sTIKPVw}`5{5+5}l7*dnGCed$7C>?f=-yFDYc6XUgGT4A&IJQ$V=gxa
zE&~`xBsH*%sRi<NceYhI%dahoPJ1?hIFQP0lHrFX3Px(mUfgy7vTsz?k<;M#e=x@B
zht%uPArLKZI{^Iz8$j%qA=q5j$8jCIg%ATMZ^ob<8(@kOg;lgTy~(Y_YI{c5E7J0%
zeY7WGiV^@)B(9EoXr^;BNBgz{kgL;GQ?yFbC4IwsBWyk5zy^vGJ%5Xc!lqPxkmhAb
z6TfQVd6^h-)22-(WV0J)0=!>RSt%+bfTuE+Y7ES8wP@^LOD%{2&qG@l3Jp?zkm(G~
z4z>b-Y+dY5;=P4a<Cx>A1u@VaLXjcPfkd_^Lg!lAy6#wj$jU&!>t_PGZeN3SZKfv<
zxWLjR0IdZSO$8Y8JrUBvJm1U|6%t}}54F)>(e3N8rXGlJFN$ejS<4cF9W3wLb27AO
zuVhBTQW9=Jcb=<)*mrVsG|d&7=GSs=*8;dFsFX%U4zeh32#T6$Hv|u0tri+~mza~$
zrTic-)TM~7r0jY0ozxo%!Zb0HEqq#Sg@*_{Qpx+V=J)aYzf;4^OA5GcTc-6aH>_Km
z4`9l^4;mz^fh;As0y5=4*lg&=Y2g!1G5s1gT4s|<4V?>D^Dx%Ain1V@?;+p-6m!|4
z&lQP*P^{%{zSpLW`1T@NRSOGS0s#>u`!GGQ<ByE&ud3pTzgfo0r8_#-pFvy|oAM?k
z4{-j%Mhnm|UBPQD)>1GJ#3Hpa63|i!0A-$!bCx2rXs~bW2oOmls+(bVccccdm}nF1
z9c}PpH8Zr3m;p8FA^T`Uur6Vq9_cTQ1{#a^|4aA`k^CHgzbuWJR0E1TYitJcVwLGT
z;8(>BBi&n#K=qiCw&!W-!J9NQe;fXO02S@$DIdqbUx&|q3pot46o65R>CI%5TPW56
zjRoL3;`2O)>`5R*x_%SNv_FJ-@Pge&g*Sx2U=2c)6y^t@s5?jzQ(Ob(z_q*pU(p$`
z$+#1Tp6#RWCcpQB->*ufa&oybk>UURh*Jq_0Ezq1zGqM>Y--%6_DoaeH!B1lHlEIZ
zLz`i~@1A1v#RU1xWTntTrZlZBMKamypu9Dt<O;JUQW<LMlj^2vUqZu|ny=Z^f+8j%
z5RnC8MgSBgHUCJ71c1Rt<Qymf&k?qYkP9HoNM(lHuIl=B@LVEpAjV2?%mDQJ44A~u
z>iCD#Dj*7%;`zFRa5b;^r_d&oe>c63#sisT!W<comBulBp-ApMirYg|6{FStS^+@b
zQO=Q{1jS%qIF%q)6raX<k7Nw0#-_P`Unkqhn$n6c682ZY)mRIg3L<A2Tv4GTbq=ZI
z#_QtLFBGqS;)UYI-p=*z@U#6OfnzRM!I&KTxI^G`tEsl<ugnD1`J3XVj2rWU%1c^i
zh;!T{4QQh%0C-u7D0))L=RJDyHS*V&J51;N+8SV(U;Xs2CQ=U=zUk-g-kl;X^G&)|
z#>hY_tYNHW)WAYO5cw(<3g|5%FjIx<i2j;iZM8YH0M?ESYg*wfXwSR2=|4$xFdD+q
zvFro1%mr3lCx0e{OcdAlgMv6oGrxp3gtbe;$4N^|v<m6*E&%a5^@SDPI!LC?RbiYn
zp!)&#E*w`WFin*F?@*NfS^OQf+E$0lg&#n6=1g-~RJH#CRks$>duIUVGc-3yU9m*M
zo;{XZ@Kvj0ZT0#)3Fj^}i~yq}Z9w$?z%jsNVUy$*XY>Nb=mm_CL;ywrMgT?tMiK!S
e0T=;z9LPV+S$p2eoZCSF0000<MNUMnLSTYX5=@Z*

literal 0
HcmV?d00001

diff --git a/addons/web/static/src/js/view_list.js b/addons/web/static/src/js/view_list.js
index e8fff450c6e..c9a65ac6c4b 100644
--- a/addons/web/static/src/js/view_list.js
+++ b/addons/web/static/src/js/view_list.js
@@ -747,6 +747,18 @@ openerp.web.ListView = openerp.web.View.extend( /** @lends openerp.web.ListView#
                     .attr('colspan', this.previous_colspan);
             this.previous_colspan = null;
         }
+    },
+    no_result: function () {
+        var help = this.options.action.help;
+        if (this.groups.group_by || !help) {
+            return;
+        }
+        this.$element.children('table').replaceWith(
+            $('<div class="oe_listview_nocontent">')
+                .append($('<img>', {
+                    src: '/web/static/src/img/empty-list-arrow.png',
+                    alt: _t("This list is empty")}))
+                .append($('<div>').html(help)));
     }
 });
 openerp.web.ListView.List = openerp.web.Class.extend( /** @lends openerp.web.ListView.List# */{
@@ -1344,6 +1356,9 @@ openerp.web.ListView.Groups = openerp.web.Class.extend( /** @lends openerp.web.L
             self.records.add(records, {silent: true});
             list.render();
             d.resolve(list);
+            if (_.isEmpty(records)) {
+                view.no_result();
+            }
         });});
         return d.promise();
     },

From da864266c0c374abecad3295f74a57b0d7a394b8 Mon Sep 17 00:00:00 2001
From: Xavier Morel <xmo@openerp.com>
Date: Tue, 3 Apr 2012 16:17:26 +0200
Subject: [PATCH 2/2] [FIX] o2m/m2m lists: only display help when there's help
 on the action... or an action at all

bzr revid: xmo@openerp.com-20120403141726-a6o4sfvifzzjy9r4
---
 addons/web/static/src/js/view_list.js | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/addons/web/static/src/js/view_list.js b/addons/web/static/src/js/view_list.js
index c9a65ac6c4b..85943732c68 100644
--- a/addons/web/static/src/js/view_list.js
+++ b/addons/web/static/src/js/view_list.js
@@ -749,8 +749,9 @@ openerp.web.ListView = openerp.web.View.extend( /** @lends openerp.web.ListView#
         }
     },
     no_result: function () {
-        var help = this.options.action.help;
-        if (this.groups.group_by || !help) {
+        if (this.groups.group_by
+            || !this.options.action
+            || !this.options.action.help) {
             return;
         }
         this.$element.children('table').replaceWith(
@@ -758,7 +759,7 @@ openerp.web.ListView = openerp.web.View.extend( /** @lends openerp.web.ListView#
                 .append($('<img>', {
                     src: '/web/static/src/img/empty-list-arrow.png',
                     alt: _t("This list is empty")}))
-                .append($('<div>').html(help)));
+                .append($('<div>').html(this.options.action.help)));
     }
 });
 openerp.web.ListView.List = openerp.web.Class.extend( /** @lends openerp.web.ListView.List# */{