From 74e1d6940da7b5f0cc8fe4b2ba60d0bb81990ba5 Mon Sep 17 00:00:00 2001 From: Jeremy Kersten Date: Mon, 17 Oct 2016 11:28:02 +0200 Subject: [PATCH] [FIX] website_blog: fix depends for post_date Before this commit, create a blog post since the backend raise an error because the post_date is False. It should never arrive, since it is a compute field that is the publish date or fallback on the create_date. But because set post_date, change the published_date, the depend from publish date cannot be triggered again since it change the post_date. So _set_post_date don't trigger _compute_post_date. And call it manually will make 'max recursion depth python'. The 'hack' to update publish date, without retrigger the _compute_post_date and set post_date manually, is to use the _write method that don't trigger all depends fields. Courtesy of @rco-odoo This commit closes #13829 --- addons/website_blog/models/website_blog.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/addons/website_blog/models/website_blog.py b/addons/website_blog/models/website_blog.py index 6045070acab..ddc1f1a04c2 100644 --- a/addons/website_blog/models/website_blog.py +++ b/addons/website_blog/models/website_blog.py @@ -101,11 +101,13 @@ class BlogPost(models.Model): blog_post.website_url = "/blog/%s/post/%s" % (slug(blog_post.blog_id), slug(blog_post)) @api.multi + @api.depends('post_date', 'visits') def _compute_ranking(self): res = {} for blog_post in self: - age = datetime.now() - fields.Datetime.from_string(blog_post.post_date) - res[blog_post.id] = blog_post.visits * (0.5 + random.random()) / max(3, age.days) + if blog_post.id: # avoid to rank one post not yet saved and so withtout post_date in case of an onchange. + age = datetime.now() - fields.Datetime.from_string(blog_post.post_date) + res[blog_post.id] = blog_post.visits * (0.5 + random.random()) / max(3, age.days) return res def _default_content(self): @@ -181,6 +183,8 @@ class BlogPost(models.Model): def _set_post_date(self): for blog_post in self: blog_post.published_date = blog_post.post_date + if not blog_post.published_date: + blog_post._write(dict(post_date=blog_post.create_date)) # dont trigger inverse function def _check_for_publication(self, vals): if vals.get('website_published'):