From 73a373fb2ac27f75b6ddd7dbfc831e4b44e8687b Mon Sep 17 00:00:00 2001 From: yograj tandel Date: Wed, 24 Feb 2021 12:10:09 +0000 Subject: [PATCH] [FIX] web_tour: tour tip does not open When mouse hover on tour droplet, it shows tip information but when click on app name(ex- expenses) and hover on tour droplet, it does not shows tip information, it is because tip is now part of o_content element i.e. controller element and when we click on app name it re-renders whole action manager and due to which tip element also removed and later tip element added but new tip insteance is not created, element of existing tip instance is added to DOM and due to which event bound on previous element is not bound on new element, to fix this we need to explicitly bind events on tip. after this commit: tip shows information even after clicking on app name as we explicitly bind events when tip is re-rendered. task-2376278 closes odoo/odoo#73304 X-original-commit: c25c1d644e84cade8766c1f89930b46e88a33087 Signed-off-by: Simon Genin (ges@odoo) --- addons/web_tour/static/src/js/tip.js | 1 + 1 file changed, 1 insertion(+) diff --git a/addons/web_tour/static/src/js/tip.js b/addons/web_tour/static/src/js/tip.js index 9d84557ee50..e9e24a67c11 100644 --- a/addons/web_tour/static/src/js/tip.js +++ b/addons/web_tour/static/src/js/tip.js @@ -164,6 +164,7 @@ var Tip = Widget.extend({ this._setupAnchor($anchor, $altAnchor); } this._bind_anchor_events(); + this._delegateEvents(); if (!this.$el) { // Ideally this case should not happen but this is still possible, // as update may be called before the `start` method is called.