From 3eb5cfb61b6bbb84043f4fa6b3fdefb0fbb320c7 Mon Sep 17 00:00:00 2001 From: "Vidhin Mehta (OpenERP)" Date: Wed, 3 Oct 2012 16:52:27 +0530 Subject: [PATCH 01/23] [IMP]remove call_backs from call method. bzr revid: vme@tinyerp.com-20121003112227-vu2crilmvnk2me8j --- addons/google_docs/static/src/js/gdocs.js | 8 ++++---- addons/process/static/src/js/process.js | 3 +-- addons/share/static/src/js/share.js | 5 ++--- 3 files changed, 7 insertions(+), 9 deletions(-) diff --git a/addons/google_docs/static/src/js/gdocs.js b/addons/google_docs/static/src/js/gdocs.js index bcfd24f8c0d..2aafdd3de4b 100644 --- a/addons/google_docs/static/src/js/gdocs.js +++ b/addons/google_docs/static/src/js/gdocs.js @@ -22,7 +22,7 @@ var _t = instance.web._t; var form = self.getParent(); form.sidebar_context().then(function (context) { var ds = new instance.web.DataSet(this, 'ir.attachment', context); - ds.call('google_doc_get', [form.dataset.model, [form.datarecord.id], context], function(r) { + ds.call('google_doc_get', [form.dataset.model, [form.datarecord.id], context]).then(function(r) { if (r == 'False') { var params = { error: response, @@ -35,7 +35,7 @@ var _t = instance.web._t; } form.reload(); }); - }) + }); } - }) -} + }); +}; diff --git a/addons/process/static/src/js/process.js b/addons/process/static/src/js/process.js index 57c6f196012..2b543484f2e 100644 --- a/addons/process/static/src/js/process.js +++ b/addons/process/static/src/js/process.js @@ -217,8 +217,7 @@ instance.web.ViewManager.include({ var dataset = new instance.web.DataSet(this, 'ir.values', this.session.user_context); var action_manager = new instance.web.ActionManager(self); dataset.call('get', - ['action', 'tree_but_open',[['ir.ui.menu', id]], dataset.context], - function(res) { + ['action', 'tree_but_open',[['ir.ui.menu', id]], dataset.context]).then(function(res) { var action = res[0][res[0].length - 1]; self.rpc("/web/action/load", { action_id: action.id, diff --git a/addons/share/static/src/js/share.js b/addons/share/static/src/js/share.js index bab3cac243f..01c1ef0a41e 100644 --- a/addons/share/static/src/js/share.js +++ b/addons/share/static/src/js/share.js @@ -24,9 +24,8 @@ openerp.share = function(session) { user_type: user_type || 'embedded', view_type: view.fields_view.type, invite: invite || false, - }, function(result) { - var share_id = result.result; - var step1 = Share.call('go_step_1', [[share_id],], function(result) { + }).then(function(share_id) { + var step1 = Share.call('go_step_1', [[share_id]]).then(function(result) { var action = result; self.do_action(action); }); From 1fe81f3a962cf1600a9aecbb22d7be9162c3a311 Mon Sep 17 00:00:00 2001 From: ggh-openerp Date: Wed, 3 Oct 2012 18:04:12 +0530 Subject: [PATCH 02/23] [IMP] In rpc method remove callback and modify related code bzr revid: ggh@tinyerp.com-20121003123412-22o4t380ipsmns2e --- .../account/static/src/js/account_move_reconciliation.js | 2 +- addons/auth_openid/static/src/js/auth_openid.js | 4 ++-- addons/board/static/src/js/dashboard.js | 6 +++--- addons/edi/static/src/js/edi.js | 6 +++--- addons/mail/static/src/js/mail.js | 2 +- addons/point_of_sale/static/src/js/devices.js | 7 +++---- addons/process/static/src/js/process.js | 2 +- addons/share/static/src/js/share.js | 2 +- addons/web_shortcuts/static/src/js/web_shortcuts.js | 4 ++-- 9 files changed, 17 insertions(+), 18 deletions(-) diff --git a/addons/account/static/src/js/account_move_reconciliation.js b/addons/account/static/src/js/account_move_reconciliation.js index 6b007e2f097..18e415a5f0a 100644 --- a/addons/account/static/src/js/account_move_reconciliation.js +++ b/addons/account/static/src/js/account_move_reconciliation.js @@ -101,7 +101,7 @@ openerp.account = function (instance) { return self.rpc("/web/action/load", { action_id: result[1], context: additional_context - }, function (result) { + }).then(function (result) { result = result.result; result.context = _.extend(result.context || {}, additional_context); result.flags = result.flags || {}; diff --git a/addons/auth_openid/static/src/js/auth_openid.js b/addons/auth_openid/static/src/js/auth_openid.js index 70739e056ed..56ec5b57d3f 100644 --- a/addons/auth_openid/static/src/js/auth_openid.js +++ b/addons/auth_openid/static/src/js/auth_openid.js @@ -69,7 +69,7 @@ instance.web.Login = instance.web.Login.extend({ _check_error: function() { var self = this; if (this.params.loginerror !== undefined) { - this.rpc('/auth_openid/login/status', {}, function(result) { + this.rpc('/auth_openid/login/status', {}).then(function(result) { if (_.contains(['success', 'failure'], result.status) && result.message) { self.do_warn('Invalid OpenID Login', result.message); } @@ -106,7 +106,7 @@ instance.web.Login = instance.web.Login.extend({ do_openid_login: function(db, openid_url) { var self = this; - this.rpc('/auth_openid/login/verify', {'db': db, 'url': openid_url}, function(result) { + this.rpc('/auth_openid/login/verify', {'db': db, 'url': openid_url}).then(function(result) { if (result.error) { self.do_warn(result.title, result.error); return; diff --git a/addons/board/static/src/js/dashboard.js b/addons/board/static/src/js/dashboard.js index 43d7ca76d39..e2d4d6246ab 100644 --- a/addons/board/static/src/js/dashboard.js +++ b/addons/board/static/src/js/dashboard.js @@ -46,7 +46,7 @@ instance.web.form.DashBoard = instance.web.form.FormWidget.extend({ delete(action.attrs.colspan); var action_id = _.str.toNumber(action.attrs.name); if (!_.isNaN(action_id)) { - self.rpc('/web/action/load', {action_id: action_id}, function(result) { + self.rpc('/web/action/load', {action_id: action_id}).then(function(result) { self.on_load_action(result, column_index + '_' + action_index, action.attrs); }); } @@ -81,7 +81,7 @@ instance.web.form.DashBoard = instance.web.form.FormWidget.extend({ this.rpc('/web/view/undo_custom', { view_id: this.view.fields_view.view_id, reset: true - }, this.do_reload); + }).then(this.do_reload); }, on_change_layout: function() { var self = this; @@ -382,7 +382,7 @@ instance.board.AddToDashboard = instance.web.search.Input.extend({ domain: domain, view_mode: view_parent.active_view, name: this.$el.find("input").val() - }, function(r) { + }).then(function(r) { if (r === false) { self.do_warn("Could not add filter to dashboard"); } else { diff --git a/addons/edi/static/src/js/edi.js b/addons/edi/static/src/js/edi.js index abb6d9a6232..4089318f3ce 100644 --- a/addons/edi/static/src/js/edi.js +++ b/addons/edi/static/src/js/edi.js @@ -15,7 +15,7 @@ openerp.edi.EdiView = openerp.web.Widget.extend({ this._super(); var self = this; var param = {"db": self.db, "token": self.token}; - return self.rpc('/edi/get_edi_document', param, this.on_document_loaded, this.on_document_failed); + return self.rpc('/edi/get_edi_document', param).done(this.on_document_loaded), fail(this.on_document_failed); }, on_document_loaded: function(docs){ this.doc = docs[0]; @@ -149,11 +149,11 @@ openerp.edi.EdiImport = openerp.web.Widget.extend({ }, do_import: function() { - this.rpc('/edi/import_edi_url', {url: this.url}, this.on_imported, this.on_imported_error); + this.rpc('/edi/import_edi_url', {url: this.url}),done(this.on_imported), fail(this.on_imported_error); }, on_imported: function(response) { if ('action' in response) { - this.rpc("/web/session/save_session_action", {the_action: response.action}, function(key) { + this.rpc("/web/session/save_session_action", {the_action: response.action}).then(function(key) { window.location = "/#sa="+encodeURIComponent(key); }); } diff --git a/addons/mail/static/src/js/mail.js b/addons/mail/static/src/js/mail.js index e0c9ac9b7fc..0ee3e6b1144 100644 --- a/addons/mail/static/src/js/mail.js +++ b/addons/mail/static/src/js/mail.js @@ -1127,7 +1127,7 @@ openerp.mail = function(session) { domains: domains || [], contexts: contexts || [], group_by_seq: groupbys || [] - }, function (results) { + }).then(function (results) { self.search_results['context'] = results.context; self.search_results['domain'] = results.domain; self.thread.destroy(); diff --git a/addons/point_of_sale/static/src/js/devices.js b/addons/point_of_sale/static/src/js/devices.js index 142d35bd340..9b38c7f72f0 100644 --- a/addons/point_of_sale/static/src/js/devices.js +++ b/addons/point_of_sale/static/src/js/devices.js @@ -37,11 +37,10 @@ function openerp_pos_devices(instance,module){ //module is instance.point_of_sal callbacks[i](params); } - this.connection.rpc('/pos/'+name, params || {}, - function(result){ + this.connection.rpc('/pos/'+name, params || {}).done(function(result){ ret.resolve(result); - }, - function(error){ + }), + fail(function(error){ ret.reject(error); }); return ret; diff --git a/addons/process/static/src/js/process.js b/addons/process/static/src/js/process.js index 57c6f196012..b13e92df33c 100644 --- a/addons/process/static/src/js/process.js +++ b/addons/process/static/src/js/process.js @@ -223,7 +223,7 @@ instance.web.ViewManager.include({ self.rpc("/web/action/load", { action_id: action.id, context: dataset.context - }, function(result) { + }).then(function(result) { action_manager.replace(self.$el); action_manager.do_action(result.result); }) diff --git a/addons/share/static/src/js/share.js b/addons/share/static/src/js/share.js index bab3cac243f..83eab6afaf2 100644 --- a/addons/share/static/src/js/share.js +++ b/addons/share/static/src/js/share.js @@ -15,7 +15,7 @@ openerp.share = function(session) { self.rpc('/web/session/eval_domain_and_context', { domains: [domain], contexts: [view.dataset.context] - }, function (result) { + }).then(function (result) { Share.create({ name: action.name, record_name: rec_name, diff --git a/addons/web_shortcuts/static/src/js/web_shortcuts.js b/addons/web_shortcuts/static/src/js/web_shortcuts.js index 743f3fc73aa..06b8fe35f73 100644 --- a/addons/web_shortcuts/static/src/js/web_shortcuts.js +++ b/addons/web_shortcuts/static/src/js/web_shortcuts.js @@ -46,7 +46,7 @@ instance.web_shortcuts.Shortcuts = instance.web.Widget.extend({ load: function() { var self = this; this.$el.find('.oe_systray_shortcuts_items').empty(); - return this.rpc('/web/shortcuts/list', {}, function(shortcuts) { + return this.rpc('/web/shortcuts/list', {}).then(function(shortcuts) { _.each(shortcuts, function(sc) { self.trigger('display', sc); }); @@ -80,7 +80,7 @@ instance.web_shortcuts.Shortcuts = instance.web.Widget.extend({ id = $link.data('id'); self.session.active_id = id; // TODO: Use do_action({menu_id: id, type: 'ir.actions.menu'}) - self.rpc('/web/menu/action', {'menu_id': id}, function(ir_menu_data) { + self.rpc('/web/menu/action', {'menu_id': id}).then(function(ir_menu_data) { if (ir_menu_data.action.length){ instance.webclient.user_menu.on_action({action_id: ir_menu_data.action[0][2].id}); } From 56477a10635b2eb2b4e5b854401f49360d45197c Mon Sep 17 00:00:00 2001 From: "Quentin (OpenERP)" Date: Fri, 12 Oct 2012 09:51:37 +0200 Subject: [PATCH 03/23] [IMP] hr: usability in hr.employee form view bzr revid: qdp-launchpad@openerp.com-20121012075137-fmfeehwehsbvh8ez --- addons/hr/hr_view.xml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/addons/hr/hr_view.xml b/addons/hr/hr_view.xml index 361bb581b14..cab93c6c14a 100644 --- a/addons/hr/hr_view.xml +++ b/addons/hr/hr_view.xml @@ -36,9 +36,11 @@ + + @@ -49,7 +51,6 @@ - From de1bd7a2cb67de5df42c802bcec24d8aacf889b1 Mon Sep 17 00:00:00 2001 From: "Quentin (OpenERP)" Date: Fri, 12 Oct 2012 12:11:26 +0200 Subject: [PATCH 04/23] [FIX] sale_stock: usability fix: onchange the product, the description field must be updated bzr revid: qdp-launchpad@openerp.com-20121012101126-tdrhbp7r7eaivoz9 --- addons/sale_stock/sale_stock_view.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/sale_stock/sale_stock_view.xml b/addons/sale_stock/sale_stock_view.xml index 8962c21dc6e..73b9d33ba90 100644 --- a/addons/sale_stock/sale_stock_view.xml +++ b/addons/sale_stock/sale_stock_view.xml @@ -56,7 +56,7 @@ + on_change="product_id_change(parent.pricelist_id,product_id,product_uom_qty,product_uom,product_uos_qty,product_uos,name,parent.partner_id, False, False, parent.date_order, product_packaging, parent.fiscal_position, False, context)"/> Date: Fri, 12 Oct 2012 15:06:39 +0200 Subject: [PATCH 05/23] [IMP] account_bank_statement: hide some menu for non-techy guys bzr revid: qdp-launchpad@openerp.com-20121012130639-q9v8ym1ucmfbn8r7 --- .../account_bank_statement_view.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/account_bank_statement_extensions/account_bank_statement_view.xml b/addons/account_bank_statement_extensions/account_bank_statement_view.xml index 1c076426752..9164c00373f 100644 --- a/addons/account_bank_statement_extensions/account_bank_statement_view.xml +++ b/addons/account_bank_statement_extensions/account_bank_statement_view.xml @@ -154,7 +154,7 @@ - + From 90066e17f4eee7747ac29ed88f7aa7ec5ac38db9 Mon Sep 17 00:00:00 2001 From: "Quentin (OpenERP)" Date: Fri, 12 Oct 2012 17:20:01 +0200 Subject: [PATCH 06/23] [IMP] hr_timesheet_sheet: usabiltiy imp bzr revid: qdp-launchpad@openerp.com-20121012152001-s008jau72n8r6ypy --- addons/hr_timesheet_sheet/hr_timesheet_sheet_view.xml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/addons/hr_timesheet_sheet/hr_timesheet_sheet_view.xml b/addons/hr_timesheet_sheet/hr_timesheet_sheet_view.xml index 7dd2b9a1b88..b247805d50d 100644 --- a/addons/hr_timesheet_sheet/hr_timesheet_sheet_view.xml +++ b/addons/hr_timesheet_sheet/hr_timesheet_sheet_view.xml @@ -55,11 +55,11 @@ diff --git a/addons/account/company.py b/addons/account/company.py index 1ec9b8c55da..409216f29f0 100644 --- a/addons/account/company.py +++ b/addons/account/company.py @@ -32,14 +32,6 @@ class res_company(osv.osv): help="If you select 'Round per Line' : for each tax, the tax amount will first be computed and rounded for each PO/SO/invoice line and then these rounded amounts will be summed, leading to the total amount for that tax. If you select 'Round Globally': for each tax, the tax amount will be computed for each PO/SO/invoice line, then these amounts will be summed and eventually this total tax amount will be rounded. If you sell with tax included, you should choose 'Round per line' because you certainly want the sum of your tax-included line subtotals to be equal to the total amount with taxes."), 'paypal_account': fields.char("Paypal Account", size=128, help="Paypal username (usually email) for receiving online payments."), 'overdue_msg': fields.text('Overdue Payments Message', translate=True), - 'property_reserve_and_surplus_account': fields.property( - 'account.account', - type='many2one', - relation='account.account', - string="Reserve and Profit/Loss Account", - view_load=True, - domain="[('type', '=', 'other')]", - help="This account is used for transferring Profit/Loss (If It is Profit: Amount will be added, Loss : Amount will be deducted.), as calculated in Profit & Loss Report"), } _defaults = { diff --git a/addons/account/company_view.xml b/addons/account/company_view.xml index 447622b57c5..73eb450ac2f 100644 --- a/addons/account/company_view.xml +++ b/addons/account/company_view.xml @@ -21,7 +21,6 @@ res.company - diff --git a/addons/account/data/configurable_account_chart.xml b/addons/account/data/configurable_account_chart.xml index b8b23344ff3..eca52109597 100644 --- a/addons/account/data/configurable_account_chart.xml +++ b/addons/account/data/configurable_account_chart.xml @@ -381,7 +381,6 @@ - diff --git a/addons/account/demo/account_minimal.xml b/addons/account/demo/account_minimal.xml index 8f858491edc..984711eceef 100644 --- a/addons/account/demo/account_minimal.xml +++ b/addons/account/demo/account_minimal.xml @@ -304,14 +304,6 @@ - - property_account_receivable - - - - - - diff --git a/addons/l10n_ch/sterchi_chart/account.xml b/addons/l10n_ch/sterchi_chart/account.xml index b04031d42ce..bd848642a97 100644 --- a/addons/l10n_ch/sterchi_chart/account.xml +++ b/addons/l10n_ch/sterchi_chart/account.xml @@ -11807,7 +11807,6 @@ - diff --git a/addons/l10n_cn/account_chart.xml b/addons/l10n_cn/account_chart.xml index e51a9d70654..afcb3e04b0c 100644 --- a/addons/l10n_cn/account_chart.xml +++ b/addons/l10n_cn/account_chart.xml @@ -957,7 +957,6 @@ - diff --git a/addons/l10n_fr/fr_pcg_taxes.xml b/addons/l10n_fr/fr_pcg_taxes.xml index b44d04439f0..78b34f2d696 100644 --- a/addons/l10n_fr/fr_pcg_taxes.xml +++ b/addons/l10n_fr/fr_pcg_taxes.xml @@ -441,7 +441,6 @@ - diff --git a/addons/l10n_gt/l10n_gt_base.xml b/addons/l10n_gt/l10n_gt_base.xml index 91561dca41b..4ba27d6a5c4 100644 --- a/addons/l10n_gt/l10n_gt_base.xml +++ b/addons/l10n_gt/l10n_gt_base.xml @@ -35,7 +35,6 @@ - diff --git a/addons/l10n_hn/l10n_hn_base.xml b/addons/l10n_hn/l10n_hn_base.xml index 1a080e3c2dd..a12d93db034 100644 --- a/addons/l10n_hn/l10n_hn_base.xml +++ b/addons/l10n_hn/l10n_hn_base.xml @@ -21,7 +21,6 @@ - diff --git a/addons/l10n_in/l10n_in_private_chart.xml b/addons/l10n_in/l10n_in_private_chart.xml index 45f5edb33d9..671fdc334d9 100644 --- a/addons/l10n_in/l10n_in_private_chart.xml +++ b/addons/l10n_in/l10n_in_private_chart.xml @@ -514,7 +514,6 @@ - diff --git a/addons/l10n_in/l10n_in_public_chart.xml b/addons/l10n_in/l10n_in_public_chart.xml index 4a4098d56c9..9612afddc39 100644 --- a/addons/l10n_in/l10n_in_public_chart.xml +++ b/addons/l10n_in/l10n_in_public_chart.xml @@ -668,7 +668,6 @@ - diff --git a/addons/l10n_nl/account_chart_netherlands.xml b/addons/l10n_nl/account_chart_netherlands.xml index 48cf78f382b..96100d9a442 100644 --- a/addons/l10n_nl/account_chart_netherlands.xml +++ b/addons/l10n_nl/account_chart_netherlands.xml @@ -4102,7 +4102,6 @@ - - - res.company.form.inherit - - res.company + + + account.config.settings.inherit + + account.config.settings + 20 - - - - + + + + + + + + + + From 04353719e97715a64c105a45aed36480dc6d02f0 Mon Sep 17 00:00:00 2001 From: niv-openerp Date: Mon, 15 Oct 2012 15:52:36 +0200 Subject: [PATCH 18/23] [IMP] removed on_close in Dialog bzr revid: nicolas.vanhoren@openerp.com-20121015135236-r5809kwwbcqo67tj --- addons/web/static/src/js/chrome.js | 5 +++-- addons/web/static/src/js/views.js | 2 +- addons/web_calendar/static/src/js/calendar.js | 12 ++++++------ addons/web_kanban/static/src/js/kanban.js | 8 ++++---- addons/web_view_editor/static/src/js/view_editor.js | 2 +- 5 files changed, 15 insertions(+), 14 deletions(-) diff --git a/addons/web/static/src/js/chrome.js b/addons/web/static/src/js/chrome.js index 078082d07fd..5f05095d880 100644 --- a/addons/web/static/src/js/chrome.js +++ b/addons/web/static/src/js/chrome.js @@ -70,7 +70,7 @@ instance.web.Dialog = instance.web.Widget.extend({ autoOpen: false, position: [false, 40], buttons: {}, - beforeClose: function () { self.on_close(); }, + beforeClose: function () { self.trigger("closing") }, resizeStop: this.on_resized }; for (var f in this) { @@ -84,6 +84,7 @@ instance.web.Dialog = instance.web.Widget.extend({ } _.extend(this.dialog_options, options); } + this.on("closing", this, this._closing); }, get_options: function(options) { var self = this, @@ -153,7 +154,7 @@ instance.web.Dialog = instance.web.Widget.extend({ close: function() { this.$el.dialog('close'); }, - on_close: function() { + _closing: function() { if (this.__tmp_dialog_destroying) return; if (this.dialog_options.destroy_on_close) { diff --git a/addons/web/static/src/js/views.js b/addons/web/static/src/js/views.js index 78cab1c3e33..1554d347552 100644 --- a/addons/web/static/src/js/views.js +++ b/addons/web/static/src/js/views.js @@ -297,7 +297,7 @@ instance.web.ActionManager = instance.web.Widget.extend({ dialogClass: executor.klass }); if(on_close) - this.dialog.on_close.add(on_close); + this.dialog.on("closing", null, on_close); } else { this.dialog_widget.destroy(); } diff --git a/addons/web_calendar/static/src/js/calendar.js b/addons/web_calendar/static/src/js/calendar.js index e4ecfdab53f..03d22e0dcbd 100644 --- a/addons/web_calendar/static/src/js/calendar.js +++ b/addons/web_calendar/static/src/js/calendar.js @@ -450,6 +450,12 @@ instance.web_calendar.CalendarFormDialog = instance.web.Dialog.extend({ this.dataset = dataset; this.view_id = view_id; this.view = view; + this.on("closing", this, function() { + if (this.view.creating_event_id) { + scheduler.deleteEvent(this.view.creating_event_id); + this.view.creating_event_id = null; + } + }); }, start: function() { var self = this; @@ -475,12 +481,6 @@ instance.web_calendar.CalendarFormDialog = instance.web.Dialog.extend({ this.view.reload_event(id); this.close(); }, - on_close: function() { - if (this.view.creating_event_id) { - scheduler.deleteEvent(this.view.creating_event_id); - this.view.creating_event_id = null; - } - } }); instance.web_calendar.Sidebar = instance.web.Widget.extend({ diff --git a/addons/web_kanban/static/src/js/kanban.js b/addons/web_kanban/static/src/js/kanban.js index d884fa6e6a2..decc20b1a03 100644 --- a/addons/web_kanban/static/src/js/kanban.js +++ b/addons/web_kanban/static/src/js/kanban.js @@ -194,10 +194,10 @@ instance.web_kanban.KanbanView = instance.web.View.extend({ }); var am = instance.webclient.action_manager; var form = am.dialog_widget.views.form.controller; - form.on("on_button_cancel", self, am.dialog.on_close); + form.on("on_button_cancel", am.dialog, am.dialog.close); form.on('record_created', self, function(r) { (new instance.web.DataSet(self, self.group_by_field.relation)).name_get([r]).then(function(new_record) { - am.dialog.on_close(); + am.dialog.close(); var domain = self.dataset.domain.slice(0); domain.push([self.group_by, '=', new_record[0][0]]); var dataset = new instance.web.DataSetSearch(self, self.dataset.model, self.dataset.get_context(), domain); @@ -672,9 +672,9 @@ instance.web_kanban.KanbanGroup = instance.web.Widget.extend({ }); var am = instance.webclient.action_manager; var form = am.dialog_widget.views.form.controller; - form.on("on_button_cancel", self, am.dialog.on_close); + form.on("on_button_cancel", am.dialog, am.dialog.close); form.on('record_saved', self, function() { - am.dialog.on_close(); + am.dialog.close(); self.view.do_reload(); }); }, diff --git a/addons/web_view_editor/static/src/js/view_editor.js b/addons/web_view_editor/static/src/js/view_editor.js index 63dc864c916..2732954097d 100644 --- a/addons/web_view_editor/static/src/js/view_editor.js +++ b/addons/web_view_editor/static/src/js/view_editor.js @@ -67,7 +67,7 @@ instance.web_view_editor.ViewEditor = instance.web.Widget.extend({ {text: _t("Close"), click: function() { self.view_edit_dialog.close(); window.location.reload(); }} ] }).open(); - this.view_edit_dialog.on_close.add_last(function(){window.location.reload();}); + this.view_edit_dialog.on("closing", this, function(){window.location.reload();}); this.main_view_id = this.parent.fields_view.view_id; this.action_manager = new instance.web.ActionManager(this); this.action_manager.appendTo(this.view_edit_dialog.$el); From a2399bc651137e27409b4c6d533b912ec8f47627 Mon Sep 17 00:00:00 2001 From: niv-openerp Date: Mon, 15 Oct 2012 15:56:07 +0200 Subject: [PATCH 19/23] [FIX] Small problem with formatting bzr revid: nicolas.vanhoren@openerp.com-20121015135607-j2c3dedpxaiuivd3 --- addons/web/static/src/js/formats.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/web/static/src/js/formats.js b/addons/web/static/src/js/formats.js index dd1fd95c97e..03b2c5b775d 100644 --- a/addons/web/static/src/js/formats.js +++ b/addons/web/static/src/js/formats.js @@ -135,7 +135,7 @@ instance.web.format_value = function (value, descriptor, value_if_empty) { Math.round((value % 1) * 60)); case 'many2one': // name_get value format - return value[1].split("\n")[0]; + return value[1] ? value[1].split("\n")[0] : value[1]; case 'one2many': case 'many2many': if (typeof value === 'string') { From bd8a4a8e5e0cf13461bc0e70a5794d18f02c045e Mon Sep 17 00:00:00 2001 From: niv-openerp Date: Mon, 15 Oct 2012 17:15:54 +0200 Subject: [PATCH 20/23] [FIX] account: reconciliation now displays a custom view bzr revid: nicolas.vanhoren@openerp.com-20121015151554-5nrchkji3dyer7u6 --- addons/account/account_view.xml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/addons/account/account_view.xml b/addons/account/account_view.xml index b0c73c132d5..cc5a075a814 100644 --- a/addons/account/account_view.xml +++ b/addons/account/account_view.xml @@ -1037,11 +1037,10 @@ --> - account.move.line.reconcile.tree account.move.line - + @@ -1049,9 +1048,10 @@ + - + @@ -1542,7 +1542,6 @@ Journal Items to Reconcile account.move.line - form account_reconciliation_list

From d20e95dce3551c7f61ae3f9595190466351e462b Mon Sep 17 00:00:00 2001 From: niv-openerp Date: Mon, 15 Oct 2012 17:33:39 +0200 Subject: [PATCH 21/23] [IMP] account: some more improvement to reconciliation bzr revid: nicolas.vanhoren@openerp.com-20121015153339-mxp25btufvkj68zh --- addons/account/account_view.xml | 8 ++++---- .../account/static/src/js/account_move_reconciliation.js | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/addons/account/account_view.xml b/addons/account/account_view.xml index cc5a075a814..c12bd98ae81 100644 --- a/addons/account/account_view.xml +++ b/addons/account/account_view.xml @@ -1040,7 +1040,7 @@ account.move.line - + @@ -1048,10 +1048,10 @@ - + - + @@ -1542,7 +1542,7 @@ Journal Items to Reconcile account.move.line - account_reconciliation_list + tree_account_reconciliation

No journal items found. diff --git a/addons/account/static/src/js/account_move_reconciliation.js b/addons/account/static/src/js/account_move_reconciliation.js index 18e415a5f0a..89ceb5be6fa 100644 --- a/addons/account/static/src/js/account_move_reconciliation.js +++ b/addons/account/static/src/js/account_move_reconciliation.js @@ -5,7 +5,7 @@ openerp.account = function (instance) { instance.web.account = {}; - instance.web.views.add('account_reconciliation_list', 'instance.web.account.ReconciliationListView'); + instance.web.views.add('tree_account_reconciliation', 'instance.web.account.ReconciliationListView'); instance.web.account.ReconciliationListView = instance.web.ListView.extend({ init: function() { this._super.apply(this, arguments); From 6034e14280cbe6a3f1d62c3cc981bb341db6a735 Mon Sep 17 00:00:00 2001 From: niv-openerp Date: Mon, 15 Oct 2012 18:29:04 +0200 Subject: [PATCH 22/23] [IMP] Added localization file for sr@latin bzr revid: nicolas.vanhoren@openerp.com-20121015162904-hhig0alct0dld5r3 --- addons/web/static/lib/datejs/globalization/sr@latin.js | 0 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 addons/web/static/lib/datejs/globalization/sr@latin.js diff --git a/addons/web/static/lib/datejs/globalization/sr@latin.js b/addons/web/static/lib/datejs/globalization/sr@latin.js new file mode 100644 index 00000000000..e69de29bb2d From b97cb148c87a63488b2f3c9c13bf2ac219388aa0 Mon Sep 17 00:00:00 2001 From: niv-openerp Date: Mon, 15 Oct 2012 18:35:27 +0200 Subject: [PATCH 23/23] [IMP] added missing localization files bzr revid: nicolas.vanhoren@openerp.com-20121015163527-i8upwcnr29yq5o7a --- addons/web/static/lib/datejs/globalization/ab-RU.js | 0 addons/web/static/lib/datejs/globalization/ar-AR.js | 0 addons/web/static/lib/datejs/globalization/bs-BS.js | 0 addons/web/static/lib/datejs/globalization/iu-CA.js | 0 addons/web/static/lib/datejs/globalization/ko-KP.js | 0 addons/web/static/lib/datejs/globalization/ml-IN.js | 0 addons/web/static/lib/datejs/globalization/oc-FR.js | 0 addons/web/static/lib/datejs/globalization/si-LK.js | 0 addons/web/static/lib/datejs/globalization/sr-RS.js | 0 addons/web/static/lib/datejs/globalization/tlh-TLH.js | 0 10 files changed, 0 insertions(+), 0 deletions(-) create mode 100644 addons/web/static/lib/datejs/globalization/ab-RU.js create mode 100644 addons/web/static/lib/datejs/globalization/ar-AR.js create mode 100644 addons/web/static/lib/datejs/globalization/bs-BS.js create mode 100644 addons/web/static/lib/datejs/globalization/iu-CA.js create mode 100644 addons/web/static/lib/datejs/globalization/ko-KP.js create mode 100644 addons/web/static/lib/datejs/globalization/ml-IN.js create mode 100644 addons/web/static/lib/datejs/globalization/oc-FR.js create mode 100644 addons/web/static/lib/datejs/globalization/si-LK.js create mode 100644 addons/web/static/lib/datejs/globalization/sr-RS.js create mode 100644 addons/web/static/lib/datejs/globalization/tlh-TLH.js diff --git a/addons/web/static/lib/datejs/globalization/ab-RU.js b/addons/web/static/lib/datejs/globalization/ab-RU.js new file mode 100644 index 00000000000..e69de29bb2d diff --git a/addons/web/static/lib/datejs/globalization/ar-AR.js b/addons/web/static/lib/datejs/globalization/ar-AR.js new file mode 100644 index 00000000000..e69de29bb2d diff --git a/addons/web/static/lib/datejs/globalization/bs-BS.js b/addons/web/static/lib/datejs/globalization/bs-BS.js new file mode 100644 index 00000000000..e69de29bb2d diff --git a/addons/web/static/lib/datejs/globalization/iu-CA.js b/addons/web/static/lib/datejs/globalization/iu-CA.js new file mode 100644 index 00000000000..e69de29bb2d diff --git a/addons/web/static/lib/datejs/globalization/ko-KP.js b/addons/web/static/lib/datejs/globalization/ko-KP.js new file mode 100644 index 00000000000..e69de29bb2d diff --git a/addons/web/static/lib/datejs/globalization/ml-IN.js b/addons/web/static/lib/datejs/globalization/ml-IN.js new file mode 100644 index 00000000000..e69de29bb2d diff --git a/addons/web/static/lib/datejs/globalization/oc-FR.js b/addons/web/static/lib/datejs/globalization/oc-FR.js new file mode 100644 index 00000000000..e69de29bb2d diff --git a/addons/web/static/lib/datejs/globalization/si-LK.js b/addons/web/static/lib/datejs/globalization/si-LK.js new file mode 100644 index 00000000000..e69de29bb2d diff --git a/addons/web/static/lib/datejs/globalization/sr-RS.js b/addons/web/static/lib/datejs/globalization/sr-RS.js new file mode 100644 index 00000000000..e69de29bb2d diff --git a/addons/web/static/lib/datejs/globalization/tlh-TLH.js b/addons/web/static/lib/datejs/globalization/tlh-TLH.js new file mode 100644 index 00000000000..e69de29bb2d