From 715e2f716a66f4187120fa9e829b26f3d5cdcd4c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Thibault=20Delavall=C3=A9e?= <tde@openerp.com>
Date: Wed, 6 Jun 2012 11:58:59 +0200
Subject: [PATCH] [IMP] mail_group: improved form view (deleted min-height,
 fixed a 'see advanced options' link.

bzr revid: tde@openerp.com-20120606095859-a6qjuuywa3wm3eu7
---
 addons/mail/mail_group_view.xml           | 61 ++++++++++++-----------
 addons/mail/static/src/css/mail_group.css | 11 ++++
 2 files changed, 44 insertions(+), 28 deletions(-)

diff --git a/addons/mail/mail_group_view.xml b/addons/mail/mail_group_view.xml
index b30133a8a0e..3bd2efe9ae6 100644
--- a/addons/mail/mail_group_view.xml
+++ b/addons/mail/mail_group_view.xml
@@ -51,46 +51,51 @@
             <field name="priority" eval="10"/>
             <field name="arch" type="xml">
                 <form string="Group Form" layout="manual">
-                    <sheet layout="auto" style="min-height: 0; max-height: none;">
-                        <group colspan="1">
-                            <field name="photo" widget='image' nolabel="1" on_change="onchange_photo(photo)"/>
-                        </group>
-                        <group colspan="3" col="6">
-                            <h2><field name="name" nolabel="1" colspan="4"/></h2>
-                            <newline/>
-                            <group colspan="2" col="2">
-                                <field name="responsible_id" colspan="2"/>
-                                <label string="Visible by non members" colspan="1"/>
-                                <field name="public" nolabel="1"/>
-                                <field name="push_to_groups" colspan="2" attrs="{'invisible':[('groups','=',False)]}"/>
-                            </group>
-                            <group colspan="4" col="4">
-                                <field name="description" colspan="4" nolabel="1"/>
-                            </group>
-                        </group>
+                    <sheet layout="auto" class="openerp_vive_les_frites">
                         <group colspan="4" col="4">
-                            <p><a href="#" class="oe_mail_group_advanced">See advanced options for groups</a></p>
-                            <newline/>
-                            <div class="oe_mail_group_advanced_details">
-                                <group colspan="4" col="6">
-                                    <field name="models" colspan="3">
+                            <group colspan="1" col="2">
+                                <field name="photo" widget='image' nolabel="1" on_change="onchange_photo(photo)"/>
+                            </group>
+                            <group colspan="3" col="6">
+                                <h2><field name="name" nolabel="1" colspan="4"/></h2>
+                                <newline/>
+                                <group colspan="2" col="2">
+                                    <field name="responsible_id" colspan="2"/>
+                                    <label string="Visible by non members" colspan="1"/>
+                                    <field name="public" nolabel="1"/>
+                                    <field name="push_to_groups" colspan="2" attrs="{'invisible':[('groups','=',False)]}"/>
+                                </group>
+                                <group colspan="4" col="4">
+                                    <field name="description" colspan="4" nolabel="1"/>
+                                </group>
+                            </group>
+                        </group>
+                        <p><a href="#" class="oe_mail_group_advanced">See advanced options for groups</a></p>
+                        <newline/>
+                        <div class="oe_mail_group_advanced_details">
+                            <group colspan="4" col="4">
+                                <group colspan="2" col="3">
+                                    <h3>Models for automatic message fetching</h3>
+                                    <field name="models" colspan="3" nolabel="1">
                                         <tree string="Document models">
                                             <field name="name"/>
                                         </tree>
                                     </field>
-                                    <field name="groups" colspan="3">
+                                </group>
+                                <group colspan="2" col="3">
+                                    <h3>User groups for message forwarding</h3>
+                                    <field name="groups" colspan="3" nolabel="1">
                                         <tree string="Document groups">
                                             <field name="name"/>
                                         </tree>
                                     </field>
                                 </group>
-                            </div>
-                        </group>
+                            </group>
+                        </div>
                         <script>
                             $('a.oe_mail_group_advanced').click(function() {
-                                var lapin = ($(this)).parents('.oe_form_autolayout').eq(0);
-                                console.log(lapin);
-                                lapin.find('div.oe_mail_group_advanced_details').toggle();
+                                var parent_node = ($(this)).parents('.oe_form_sheet').eq(0);
+                                parent_node.find('div.oe_mail_group_advanced_details').toggle();
                             });
                         </script>
                     </sheet>
diff --git a/addons/mail/static/src/css/mail_group.css b/addons/mail/static/src/css/mail_group.css
index 13fd1567b77..05656a0b431 100644
--- a/addons/mail/static/src/css/mail_group.css
+++ b/addons/mail/static/src/css/mail_group.css
@@ -5,6 +5,17 @@
 div.oe_mail_group_advanced_details {
   display: none;
 }
+ 
+.oe_form_sheetbg.openerp_vive_les_frites {
+  min-height: 0px;
+  max-height: none;
+}
+ 
+.oe_form_sheetbg.openerp_vive_les_frites .oe_form_sheet {
+  min-height: 0px;
+  max-height: none;
+}
+
 
 /* ------------------------------ */
 /* Group Kanban                   */