From 70da147e9be74757f41a9797ec218c6945a0876c Mon Sep 17 00:00:00 2001
From: oco-odoo <oco@odoo.com>
Date: Thu, 2 Apr 2020 09:07:50 +0000
Subject: [PATCH] [IMP] account: bank account journals form: hide related
 fields when bank_account_id isn't set

Showing these fields does not actually make sense when bank_account_id isn't set as well, since setting them and saving will result in them losing their value (as they're actually related on an empty field). We need to hide them while bank_account_id is not set.

closes odoo/odoo#48842

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
---
 addons/account/views/account_view.xml  | 2 +-
 addons/l10n_ch/views/res_bank_view.xml | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/addons/account/views/account_view.xml b/addons/account/views/account_view.xml
index 5d7691b4097..c75900f444d 100644
--- a/addons/account/views/account_view.xml
+++ b/addons/account/views/account_view.xml
@@ -275,7 +275,7 @@
                                     <group>
                                         <field name="company_partner_id" invisible="1"/>
                                         <field name="bank_account_id" context="{'default_partner_id': company_partner_id, 'form_view_ref': 'account.view_company_partner_bank_form'}"/>
-                                        <field name="bank_id"/>
+                                        <field name="bank_id" attrs="{'invisible': [('bank_account_id', '=', False)]}"/>
                                     </group>
                                     <group >
                                         <field name="bank_statements_source" widget="radio" attrs="{'required': [('type', '=', 'bank')]}"  groups="account.group_account_readonly"/>
diff --git a/addons/l10n_ch/views/res_bank_view.xml b/addons/l10n_ch/views/res_bank_view.xml
index 33683d3f6d2..e5503543f5d 100644
--- a/addons/l10n_ch/views/res_bank_view.xml
+++ b/addons/l10n_ch/views/res_bank_view.xml
@@ -45,7 +45,7 @@
             <field name="inherit_id" ref="account.view_account_journal_form"/>
             <field name="arch" type="xml">
                 <xpath expr="//field[@name='bank_account_id']" position="after">
-                    <field name="l10n_ch_postal" attrs="{'invisible': [('type', 'not in', ['bank', 'cash'])]}"/>
+                    <field name="l10n_ch_postal" attrs="{'invisible': [('bank_account_id', '=', False)]}"/>
                 </xpath>
             </field>
         </record>