From 70c953c26a5effbcb6509d8c31822f0070c8b87b Mon Sep 17 00:00:00 2001
From: sofiagvaladze <sgv@odoo.com>
Date: Mon, 19 Sep 2022 09:24:16 +0000
Subject: [PATCH] [IMP] hr_contract: Contracts smartbutton

purpose:
Contract management is a prior thing on an employee profile;
Thus, Contract smartbutton should be in the second position,
after Documents smartbutton, in case documents_hr is installed.

task - 2984690

closes odoo/odoo#100532

Related: odoo/enterprise#31481
Signed-off-by: Kevin Baptiste <kba@odoo.com>
---
 .../hr_contract/views/hr_contract_views.xml   | 62 +++++++++++--------
 1 file changed, 37 insertions(+), 25 deletions(-)

diff --git a/addons/hr_contract/views/hr_contract_views.xml b/addons/hr_contract/views/hr_contract_views.xml
index 2152727d90e..eb3e8dddf29 100644
--- a/addons/hr_contract/views/hr_contract_views.xml
+++ b/addons/hr_contract/views/hr_contract_views.xml
@@ -6,6 +6,43 @@
             <field name="model">hr.employee</field>
             <field name="inherit_id" ref="hr.view_employee_form"/>
             <field name="priority" eval="70" />
+            <field name="arch" type="xml">
+                <data>
+                    <xpath expr="//page[@name='hr_settings']//field[@name='employee_type']" position="after">
+                        <field name="first_contract_date"
+                               attrs="{'invisible' : ['|', ('employee_type', 'not in', ['employee', 'student']), ('first_contract_date', '=', False)]}"
+                               readonly="1"/>
+                    </xpath>
+                    <xpath expr="//field[@name='bank_account_id']" position="replace">
+                        <field name="bank_account_id" context="{'display_partner':True}" attrs="{'invisible' : [('address_home_id', '=', False)]}"/>
+                    </xpath>
+                    <xpath expr="//field[@name='resource_calendar_id']" position="replace">
+                        <field name="calendar_mismatch" invisible="1"/>
+                        <label for="resource_calendar_id"/>
+                        <div>
+                            <field name="resource_calendar_id" required="1" nolabel="1"/>
+                            <span attrs="{'invisible': [('calendar_mismatch', '=', False)]}"
+                                class="fa fa-exclamation-triangle text-danger o_calendar_warning ms-3"
+                                data-tooltip-template="hr_contract.CalendarMismatch"
+                                data-tooltip-info='{
+                                        "text":"Calendar Mismatch : The employee&apos;s calendar does not match this contract&apos;s calendar. This could lead to unexpected behaviors."
+                                    }'>
+                            </span>
+                        </div>
+                    </xpath>
+                    <field name="job_id" position="before">
+                        <field name="contract_id" groups="hr_contract.group_hr_contract_manager"/>
+                    </field>
+                </data>
+            </field>
+        </record>
+
+        <!-- This part of the view is defined separately as we want to give priority to the smartbutton. -->
+        <record id="hr_hr_employee_view_form3" model="ir.ui.view">
+            <field name="name">hr.hr.employee.view.form3</field>
+            <field name="model">hr.employee</field>
+            <field name="inherit_id" ref="hr.view_employee_form"/>
+            <field name="priority" eval="2" />
             <field name="arch" type="xml">
                 <data>
                     <div name="button_box" position="inside">
@@ -42,31 +79,6 @@
                             </div>
                         </button>
                     </div>
-                    <xpath expr="//page[@name='hr_settings']//field[@name='employee_type']" position="after">
-                        <field name="first_contract_date"
-                               attrs="{'invisible' : ['|', ('employee_type', 'not in', ['employee', 'student']), ('first_contract_date', '=', False)]}"
-                               readonly="1"/>
-                    </xpath>
-                    <xpath expr="//field[@name='bank_account_id']" position="replace">
-                        <field name="bank_account_id" context="{'display_partner':True}" attrs="{'invisible' : [('address_home_id', '=', False)]}"/>
-                    </xpath>
-                    <xpath expr="//field[@name='resource_calendar_id']" position="replace">
-                        <field name="calendar_mismatch" invisible="1"/>
-                        <label for="resource_calendar_id"/>
-                        <div>
-                            <field name="resource_calendar_id" required="1" nolabel="1"/>
-                            <span attrs="{'invisible': [('calendar_mismatch', '=', False)]}"
-                                class="fa fa-exclamation-triangle text-danger o_calendar_warning ms-3"
-                                data-tooltip-template="hr_contract.CalendarMismatch"
-                                data-tooltip-info='{
-                                        "text":"Calendar Mismatch : The employee&apos;s calendar does not match this contract&apos;s calendar. This could lead to unexpected behaviors."
-                                    }'>
-                            </span>
-                        </div>
-                    </xpath>
-                    <field name="job_id" position="before">
-                        <field name="contract_id" groups="hr_contract.group_hr_contract_manager"/>
-                    </field>
                 </data>
             </field>
         </record>