From 70c6d3b04c43a36446052c4ab8976c3d50ed4666 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lucas=20Lef=C3=A8vre?= Date: Wed, 9 Jan 2019 13:32:57 +0100 Subject: [PATCH] [Fix] web: make sidebar filter generic Adding `res_model` and `res_fields` attributes on a field of a calendar view adds a filter in the sidebar. It saves the result as the defined model and should save it in the defined field. However `partner_id` has been hardcoded in the rpc call that creates the record. This breaks genericity, it cannot be used with another field than `partner_id`. This commit makes this generic by correctly setting the field name in the rpc call. --- addons/web/static/src/js/views/calendar/calendar_renderer.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/addons/web/static/src/js/views/calendar/calendar_renderer.js b/addons/web/static/src/js/views/calendar/calendar_renderer.js index c2c90ea7e62..2720224fe39 100644 --- a/addons/web/static/src/js/views/calendar/calendar_renderer.js +++ b/addons/web/static/src/js/views/calendar/calendar_renderer.js @@ -112,11 +112,13 @@ var SidebarFilter = Widget.extend(FieldManagerMixin, { _onFieldChanged: function (event) { var self = this; event.stopPropagation(); + var createValues = {'user_id': session.uid}; var value = event.data.changes[this.write_field].id; + createValues[this.write_field] = value; this._rpc({ model: this.write_model, method: 'create', - args: [{'user_id': session.uid,'partner_id': value,}], + args: [createValues], }) .then(function () { self.trigger_up('changeFilter', {