From 6ffd3d30266efbe7fbf2e04bfa59452af25b7a91 Mon Sep 17 00:00:00 2001 From: Romain Derie Date: Wed, 25 Oct 2023 01:20:27 +0200 Subject: [PATCH] [FIX] website: don't add gmap iframe in right panel DOM in test mode Previous commit(s) did improve the preview of snippets when dragged and dropped but also the `t-snippet-call` capability of some snippets. Part of that improvement was to add snippet `onBuilt` JS output in the snippet XML definition directly. For google and facebook snippets, it means firing a request to those websites when entering edit mode. It's not that bad (considering the trade-off of the preview and t-snippet-call), but will need to be re-discussed later post freeze to find a better way to not fire those requests ideally when the snippet is called in the right panel (but would need the preview to still work). For the meantime, this request seems to be making a test fail (`test_01_menu_hierarchies`) due to the gmap API call being returned after the test has been marked as successful. Before investigating further, this commit just prevent the iframe to show up when in test mode so we can merge this work which is needed for tomorrow freeze. closes odoo/odoo#138748 Related: odoo/design-themes#726 Signed-off-by: Romain Derie (rde) --- addons/website/views/snippets/s_map.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/website/views/snippets/s_map.xml b/addons/website/views/snippets/s_map.xml index 05a544e54a1..ee25c1d20da 100644 --- a/addons/website/views/snippets/s_map.xml +++ b/addons/website/views/snippets/s_map.xml @@ -9,7 +9,7 @@ An address must be specified for a map to be embedded -