From 6fea5b42d6ddabb83daf95b8d68021b05144cf42 Mon Sep 17 00:00:00 2001
From: Julien Mougenot <jum@odoo.com>
Date: Mon, 16 Sep 2019 13:47:41 +0000
Subject: [PATCH] [IMP] *: editable readonly list views: adapt views

Since the commit allowing all list views to be editable, there are some
views in which we need to ensure that certain fields are always readonly.

Affected modules:
- account
- crm
- product
- purchase
- sale

Task 1967602
---
 addons/account/views/account_view.xml    | 2 +-
 addons/crm/views/crm_lead_views.xml      | 6 +++---
 addons/product/views/product_views.xml   | 2 +-
 addons/purchase/views/purchase_views.xml | 4 ++--
 addons/sale/views/sale_views.xml         | 2 +-
 5 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/addons/account/views/account_view.xml b/addons/account/views/account_view.xml
index 86e8dfff114..9276f638f59 100644
--- a/addons/account/views/account_view.xml
+++ b/addons/account/views/account_view.xml
@@ -149,7 +149,7 @@
                     <field name='sequence' widget='handle'/>
                     <field name="name"/>
                     <field name="type"/>
-                    <field name="journal_group_ids" widget="many2many_tags"/>
+                    <field name="journal_group_ids" widget="many2many_tags" readonly="1"/>
                     <field name="company_id" groups="base.group_multi_company"/>
                 </tree>
             </field>
diff --git a/addons/crm/views/crm_lead_views.xml b/addons/crm/views/crm_lead_views.xml
index a96c46d3cdb..c0e9111feb1 100644
--- a/addons/crm/views/crm_lead_views.xml
+++ b/addons/crm/views/crm_lead_views.xml
@@ -592,11 +592,11 @@
                     <field name="state_id" optional="hide"/>
                     <field name="country_id" optional="show"/>
                     <field name="activity_date_deadline" optional="show"/>
-                    <field name="activity_summary" optional="show"/>
+                    <field name="activity_summary" optional="show" readonly="1"/>
                     <field name="medium_id" invisible="1"/>
                     <field name="campaign_id" invisible="1"/>
                     <field name="source_id" invisible="1"/>
-                    <field name="stage_id" optional="show"/>
+                    <field name="stage_id" required="1" optional="show"/>
                     <field name="planned_revenue" sum="Expected Revenues" optional="show"/>
                     <field name="probability" avg="Avg. of Probability" optional="show"/>
                     <field name="user_id" optional="hide"/>
@@ -646,7 +646,7 @@
                     <field name="activity_date_deadline"/>
                     <field name="activity_type_id"/>
                     <field name="activity_summary"/>
-                    <field name="stage_id"/>
+                    <field name="stage_id" required="1"/>
                     <field name="planned_revenue"/>
                     <field name="date_deadline"/>
                 </tree>
diff --git a/addons/product/views/product_views.xml b/addons/product/views/product_views.xml
index 17ced8bd480..33c51a98d11 100644
--- a/addons/product/views/product_views.xml
+++ b/addons/product/views/product_views.xml
@@ -300,7 +300,7 @@
                     <field name="default_code" optional="show"/>
                     <field name="barcode" optional="hide"/>
                     <field name="name"/>
-                    <field name="product_template_attribute_value_ids" widget="many2many_tags" groups="product.group_product_variant"/>
+                    <field name="product_template_attribute_value_ids" widget="many2many_tags" groups="product.group_product_variant" readonly="1"/>
                     <field name="company_id" groups="base.group_multi_company" optional="hide"/>
                     <field name="lst_price" optional="show" string="Sales Price"/>
                     <field name="standard_price" optional="show"/>
diff --git a/addons/purchase/views/purchase_views.xml b/addons/purchase/views/purchase_views.xml
index 8bf7e32695f..8e52f9d472a 100644
--- a/addons/purchase/views/purchase_views.xml
+++ b/addons/purchase/views/purchase_views.xml
@@ -470,7 +470,7 @@
                 <tree decoration-bf="message_unread==True" decoration-muted="state=='cancel'" decoration-info="state in ('wait','confirmed')" string="Purchase Order">
                     <field name="message_unread" invisible="1"/>
                     <field name="partner_ref" optional="hide"/>
-                    <field name="name" string="Reference"/>
+                    <field name="name" string="Reference" readonly="1"/>
                     <field name="date_order" invisible="not context.get('quotation_only', False)" optional="show"/>
                     <field name="date_approve" invisible="context.get('quotation_only', False)" optional="show"/>
                     <field name="partner_id"/>
@@ -495,7 +495,7 @@
                 <tree decoration-bf="message_unread==True" decoration-muted="state=='cancel'" decoration-info="state in ('wait','confirmed')" string="Purchase Order">
                     <field name="message_unread" invisible="1"/>
                     <field name="partner_ref" optional="hide"/>
-                    <field name="name" string="Reference"/>
+                    <field name="name" string="Reference" readonly="1"/>
                     <field name="date_order" invisible="not context.get('quotation_only', False)" optional="show"/>
                     <field name="date_approve" invisible="context.get('quotation_only', False)" optional="show"/>
                     <field name="partner_id"/>
diff --git a/addons/sale/views/sale_views.xml b/addons/sale/views/sale_views.xml
index a5be54233b5..831ec767da2 100644
--- a/addons/sale/views/sale_views.xml
+++ b/addons/sale/views/sale_views.xml
@@ -214,7 +214,7 @@
             <field name="arch" type="xml">
                 <tree string="Quotation" class="o_sale_order" decoration-bf="message_needaction==True" decoration-muted="state=='cancel'">
                     <field name="message_needaction" invisible="1"/>
-                    <field name="name" string="Quotation Number"/>
+                    <field name="name" string="Quotation Number" readonly="1"/>
                     <field name="create_date" string="Create Date"/>
                     <field name="commitment_date"/>
                     <field name="expected_date"/>