From 6faad54a2f6f07c8a825f5553d0ed3d65527df7a Mon Sep 17 00:00:00 2001
From: Yannick Tivisse <yti@odoo.com>
Date: Wed, 15 Jun 2022 11:28:18 +0000
Subject: [PATCH] [IMP] hr_recruitment_skills: Remove Populate button on search
 view modif

Purpose
=======

It becomes unclear what the button does once the search view doesn't
filter on the related job's applications (aka the filter is removed
for example)

Taskid: 2884356
Part-of: odoo/odoo#93684
---
 .../static/src/js/hr_applicant_kanban_view.js  | 18 ++++++++++++++++++
 .../hr_recruitment_populate_wizard_views.xml   |  2 +-
 2 files changed, 19 insertions(+), 1 deletion(-)

diff --git a/addons/hr_recruitment_skills/static/src/js/hr_applicant_kanban_view.js b/addons/hr_recruitment_skills/static/src/js/hr_applicant_kanban_view.js
index 4902f8488fd..a8dbf362743 100644
--- a/addons/hr_recruitment_skills/static/src/js/hr_applicant_kanban_view.js
+++ b/addons/hr_recruitment_skills/static/src/js/hr_applicant_kanban_view.js
@@ -26,6 +26,24 @@ odoo.define('hr.applicant.view.kanban', function (require) {
                     }
                 });
             });
+        },
+
+        _onSearch: async function (searchQuery) {
+            this._super.apply(this, arguments);
+            var activeID = this.model.get(this.handle).context.active_id;
+            var jobID = undefined;
+            if (searchQuery.domain && !_.isEmpty(searchQuery.domain)) {
+                searchQuery.domain.forEach(elem => {
+                    if (elem.length === 3 && elem[0] === 'job_id') {
+                        jobID = elem[2];
+                    }
+                })
+            }
+            if (activeID === jobID) {
+                $('button.o_button_recruitment_populate').removeClass('d-none');
+            } else {
+                $('button.o_button_recruitment_populate').addClass('d-none');
+            }
         }
     });
 
diff --git a/addons/hr_recruitment_skills/wizard/hr_recruitment_populate_wizard_views.xml b/addons/hr_recruitment_skills/wizard/hr_recruitment_populate_wizard_views.xml
index 37ca3ec32c8..5a18478945f 100644
--- a/addons/hr_recruitment_skills/wizard/hr_recruitment_populate_wizard_views.xml
+++ b/addons/hr_recruitment_skills/wizard/hr_recruitment_populate_wizard_views.xml
@@ -23,7 +23,7 @@
                 </sheet>
                 <footer>
                     <button string="Populate" name="action_validate" type="object" class="btn-primary"/>
-                    <button special="cancel" string="Close" type="object" class="btn-primary"/>
+                    <button special="cancel" string="Close" type="object" class="btn-secondary"/>
                 </footer>
             </form>
         </field>