[MERGE] forward port branch saas-11 up to 1304d13

2016-10-27 17:55:47 +02:00
parent 7a65ec28b9 1304d13c7f
commit 6f8e40cdec
24 changed files with 440 additions and 89 deletions
@@ -793,18 +793,19 @@ var BufferedDataSet = DataSetStatic.extend({
        var def = $.Deferred();
        this.mutex.exec(function () {
            var dirty = false;
-            _.each(data, function (v, k) {
-                if (!_.isEqual(v, cached.values[k])) {
+            // _.each is broken if a field "length" is present
+            for (var k in data) {
+                if (!_.isEqual(data[k], cached.values[k])) {
                    dirty = true;
-                    if (_.isEqual(v, cached.from_read[k])) { // clean changes
+                    if (_.isEqual(data[k], cached.from_read[k])) { // clean changes
                        delete cached.changes[k];
                    } else {
-                        cached.changes[k] = v;
+                        cached.changes[k] = data[k];
                    }
                } else {
                    delete data[k];
                }
-            });
+            }
            self._update_cache(id, options);

            if (dirty) {