From 6efe469941c62dfe7c8f8babb860b88f1179e12e Mon Sep 17 00:00:00 2001 From: Samuel Degueldre Date: Tue, 7 Apr 2020 10:21:46 +0000 Subject: [PATCH] [REF] web_editor, web: remove unused getRecordInfo event and methods In the 12.3 editor revert, the handler for the getRecordInfo event was removed, but the code that triggered this event was forgotten and now doesn't do anything. This commit removes this dead code. closes odoo/odoo#49126 Signed-off-by: Quentin Smetz (qsm) --- addons/web/static/src/js/widgets/colorpicker.js | 6 ------ addons/web_editor/static/src/js/editor/snippets.editor.js | 6 ------ .../web_editor/static/src/js/editor/snippets.options.js | 5 ----- .../static/src/js/wysiwyg/widgets/alt_dialog.js | 7 ------- .../static/src/js/wysiwyg/widgets/link_dialog.js | 7 ------- .../static/src/js/wysiwyg/widgets/media_dialog.js | 8 -------- addons/web_editor/static/src/js/wysiwyg/wysiwyg.js | 2 -- 7 files changed, 41 deletions(-) diff --git a/addons/web/static/src/js/widgets/colorpicker.js b/addons/web/static/src/js/widgets/colorpicker.js index 8c3556df60f..9ca04ea48d0 100644 --- a/addons/web/static/src/js/widgets/colorpicker.js +++ b/addons/web/static/src/js/widgets/colorpicker.js @@ -30,12 +30,6 @@ var ColorpickerWidget = Widget.extend({ init: function (parent, options) { this._super(...arguments); options = options || {}; - this.trigger_up('getRecordInfo', { - recordInfo: options, - callback: function (recordInfo) { - _.defaults(options, recordInfo); - }, - }); this.pickerFlag = false; this.sliderFlag = false; diff --git a/addons/web_editor/static/src/js/editor/snippets.editor.js b/addons/web_editor/static/src/js/editor/snippets.editor.js index cb02079a93c..4795ce409a7 100644 --- a/addons/web_editor/static/src/js/editor/snippets.editor.js +++ b/addons/web_editor/static/src/js/editor/snippets.editor.js @@ -1019,12 +1019,6 @@ var SnippetsMenu = Widget.extend({ init: function (parent, options) { this._super.apply(this, arguments); options = options || {}; - this.trigger_up('getRecordInfo', { - recordInfo: options, - callback: function (recordInfo) { - _.defaults(options, recordInfo); - }, - }); this.options = options; if (!this.options.snippets) { diff --git a/addons/web_editor/static/src/js/editor/snippets.options.js b/addons/web_editor/static/src/js/editor/snippets.options.js index 0fcdd034e4d..8d62438bbbb 100644 --- a/addons/web_editor/static/src/js/editor/snippets.options.js +++ b/addons/web_editor/static/src/js/editor/snippets.options.js @@ -4547,11 +4547,6 @@ registry.many2one = SnippetOptionWidget.extend({ */ start: function () { var self = this; - this.trigger_up('getRecordInfo', _.extend(this.options, { - callback: function (recordInfo) { - _.defaults(self.options, recordInfo); - }, - })); this.Model = this.$target.data('oe-many2one-model'); this.ID = +this.$target.data('oe-many2one-id'); diff --git a/addons/web_editor/static/src/js/wysiwyg/widgets/alt_dialog.js b/addons/web_editor/static/src/js/wysiwyg/widgets/alt_dialog.js index 80f143b646c..3668636c33a 100644 --- a/addons/web_editor/static/src/js/wysiwyg/widgets/alt_dialog.js +++ b/addons/web_editor/static/src/js/wysiwyg/widgets/alt_dialog.js @@ -24,13 +24,6 @@ var AltDialog = Dialog.extend({ title: _t("Change media description and tooltip") }, options)); - this.trigger_up('getRecordInfo', { - recordInfo: options, - callback: function (recordInfo) { - _.defaults(options, recordInfo); - }, - }); - this.media = media; var allEscQuots = /"/g; this.alt = ($(this.media).attr('alt') || "").replace(allEscQuots, '"'); diff --git a/addons/web_editor/static/src/js/wysiwyg/widgets/link_dialog.js b/addons/web_editor/static/src/js/wysiwyg/widgets/link_dialog.js index 53e0d725bd2..e7fd83b0044 100644 --- a/addons/web_editor/static/src/js/wysiwyg/widgets/link_dialog.js +++ b/addons/web_editor/static/src/js/wysiwyg/widgets/link_dialog.js @@ -43,13 +43,6 @@ var LinkDialog = Dialog.extend({ // all btn-* classes anyway. ]; - this.trigger_up('getRecordInfo', { - recordInfo: this.options, - callback: function (recordInfo) { - _.defaults(self.options, recordInfo); - }, - }); - // data is used in the dialog template. this.props = options.props || {}; diff --git a/addons/web_editor/static/src/js/wysiwyg/widgets/media_dialog.js b/addons/web_editor/static/src/js/wysiwyg/widgets/media_dialog.js index 22815a8f641..c291611a9ee 100644 --- a/addons/web_editor/static/src/js/wysiwyg/widgets/media_dialog.js +++ b/addons/web_editor/static/src/js/wysiwyg/widgets/media_dialog.js @@ -52,14 +52,6 @@ var MediaDialog = Dialog.extend({ save_text: _t("Add"), }, options)); - this.trigger_up('getRecordInfo', { - recordInfo: options, - type: 'media', - callback: function (recordInfo) { - _.defaults(options, recordInfo); - }, - }); - if (!options.noImages) { this.imageWidget = new MediaModules.ImageWidget(this, media, options); } diff --git a/addons/web_editor/static/src/js/wysiwyg/wysiwyg.js b/addons/web_editor/static/src/js/wysiwyg/wysiwyg.js index 586a26b8478..b7e9cc03c49 100644 --- a/addons/web_editor/static/src/js/wysiwyg/wysiwyg.js +++ b/addons/web_editor/static/src/js/wysiwyg/wysiwyg.js @@ -30,10 +30,8 @@ var Wysiwyg = Widget.extend({ * @options {integer} [options.recordInfo.res_id] * @options {String} [options.recordInfo.data_res_model] * @options {integer} [options.recordInfo.data_res_id] - * @see _onGetRecordInfo * @see _getAttachmentsDomain in /wysiwyg/widgets/media.js * @options {Object} options.attachments - * @see _onGetRecordInfo * @see _getAttachmentsDomain in /wysiwyg/widgets/media.js (for attachmentIDs) * @options {function} options.generateOptions * called with the summernote configuration object used before sending to summernote