From 6e4862d2ba0675b920cb27cd063db0a2347f3fc2 Mon Sep 17 00:00:00 2001
From: Mathieu Duckerts-Antoine <dam@odoo.com>
Date: Fri, 14 Apr 2023 12:08:02 +0000
Subject: [PATCH] [IMP] web: filter menu closed on advanced search

We make the filter menu close itself when the user click on its item
"Advanced Search".

Part-of: odoo/odoo#117951
---
 addons/web/static/src/search/filter_menu/filter_menu.xml     | 2 +-
 .../web/static/tests/search/advanced_search_dialog_tests.js  | 5 +++--
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/addons/web/static/src/search/filter_menu/filter_menu.xml b/addons/web/static/src/search/filter_menu/filter_menu.xml
index e1bda7f359d..56f575634c1 100644
--- a/addons/web/static/src/search/filter_menu/filter_menu.xml
+++ b/addons/web/static/src/search/filter_menu/filter_menu.xml
@@ -45,7 +45,7 @@
             <t t-if="items.length">
                 <div role="separator" class="dropdown-divider"/>
             </t>
-            <DropdownItem onSelected.bind="onAdvancedSearchClick" parentClosingMode="'none'">Advanced Search</DropdownItem>
+            <DropdownItem onSelected.bind="onAdvancedSearchClick">Advanced Search</DropdownItem>
         </Dropdown>
     </t>
 
diff --git a/addons/web/static/tests/search/advanced_search_dialog_tests.js b/addons/web/static/tests/search/advanced_search_dialog_tests.js
index 655e1438c4b..709426c116e 100644
--- a/addons/web/static/tests/search/advanced_search_dialog_tests.js
+++ b/addons/web/static/tests/search/advanced_search_dialog_tests.js
@@ -165,8 +165,10 @@ QUnit.module("Search", (hooks) => {
         await makeTestComponent();
         await toggleFilterMenu(target);
         assert.containsNone(target, ".modal");
+        assert.containsOnce(target, ".o_filter_menu .dropdown-menu");
 
         await openAdvancedSearchDialog(target);
+        assert.containsNone(target, ".o_filter_menu .dropdown-menu");
         assert.containsOnce(target, ".modal");
         assert.containsOnce(target, ".modal .modal-header h4");
         assert.strictEqual(target.querySelector(".modal header h4").innerText, "Advanced Search");
@@ -178,14 +180,13 @@ QUnit.module("Search", (hooks) => {
 
         await click(target, ".modal footer button:nth-child(2)");
         assert.containsNone(target, ".modal");
-        assert.containsOnce(target, ".o_filter_menu .dropdown-menu");
 
+        await toggleFilterMenu(target);
         await openAdvancedSearchDialog(target);
         assert.containsOnce(target, ".modal");
 
         await click(target, ".modal footer button:nth-child(1)");
         assert.containsNone(target, ".modal");
-        assert.containsNone(target, ".o_filter_menu .dropdown-menu");
     });
 
     QUnit.test("start with an empty query", async function (assert) {