pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIX] report: don't hide errors in custom reports

Browse Source 
If a custom report's render_html raises a KeyError for some
reason, Report.get_html would swallow the exception and fallback
on generic HTML rendering, usually blowing up with unfathomable
errors of missing rendering context data.

Check if a custom report object exists instead of waiting for a
KeyError.
This commit is contained in:
xmo-odoo
2016-05-13 17:28:19 +02:00
parent 91c9284951
commit 6d73087d96
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/report/models/report.py
+4 -4
View File
@@ -115,11 +115,11 @@ class Report(osv.Model):
""" """
# If the report is using a custom model to render its html, we must use it. # If the report is using a custom model to render its html, we must use it.
# Otherwise, fallback on the generic html rendering. # Otherwise, fallback on the generic html rendering.
try: report_model_name = 'report.%s' % report_name
report_model_name = 'report.%s' % report_name particularreport_obj = self.pool.get(report_model_name)
particularreport_obj = self.pool[report_model_name] if particularreport_obj is not None:
return particularreport_obj.render_html(cr, uid, ids, data=data, context=context) return particularreport_obj.render_html(cr, uid, ids, data=data, context=context)
except KeyError: else:
report = self._get_report_from_name(cr, uid, report_name) report = self._get_report_from_name(cr, uid, report_name)
report_obj = self.pool[report.model] report_obj = self.pool[report.model]
docs = report_obj.browse(cr, uid, ids, context=context) docs = report_obj.browse(cr, uid, ids, context=context)