From 6d4ff4517427c41915fa8bf51b1bfee67738327f Mon Sep 17 00:00:00 2001
From: Yannick Tivisse <yti@odoo.com>
Date: Fri, 18 Nov 2022 13:08:02 +0000
Subject: [PATCH] [FIX] hr_contract: Fix transitive relationship on contract
 res.groups

closes odoo/odoo#106256

X-original-commit: d9a475518914b31f0b2088444a4d23f00d2826a6
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Co-authored-by: Xavier BOL (xbo) <xbo@odoo.com>
---
 addons/hr_contract/models/hr_contract.py         | 2 +-
 addons/hr_contract/report/hr_contract_history.py | 2 +-
 addons/hr_contract/security/security.xml         | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/addons/hr_contract/models/hr_contract.py b/addons/hr_contract/models/hr_contract.py
index 167259a5877..db4eb8e4c08 100644
--- a/addons/hr_contract/models/hr_contract.py
+++ b/addons/hr_contract/models/hr_contract.py
@@ -69,7 +69,7 @@ class Contract(models.Model):
 
     hr_responsible_id = fields.Many2one('res.users', 'HR Responsible', tracking=True,
         help='Person responsible for validating the employee\'s contracts.', domain=_get_hr_responsible_domain)
-    calendar_mismatch = fields.Boolean(compute='_compute_calendar_mismatch')
+    calendar_mismatch = fields.Boolean(compute='_compute_calendar_mismatch', compute_sudo=True)
     first_contract_date = fields.Date(related='employee_id.first_contract_date')
 
     @api.depends('employee_id.resource_calendar_id', 'resource_calendar_id')
diff --git a/addons/hr_contract/report/hr_contract_history.py b/addons/hr_contract/report/hr_contract_history.py
index fd63409d917..26ea29198bf 100644
--- a/addons/hr_contract/report/hr_contract_history.py
+++ b/addons/hr_contract/report/hr_contract_history.py
@@ -42,7 +42,7 @@ class ContractHistory(models.Model):
     country_code = fields.Char(related='company_country_id.code', depends=['company_country_id'], readonly=True)
     currency_id = fields.Many2one(string='Currency', related='company_id.currency_id', readonly=True)
     contract_type_id = fields.Many2one('hr.contract.type', 'Contract Type', readonly=True)
-    contract_ids = fields.One2many('hr.contract', string='Contracts', compute='_compute_contract_ids', readonly=True)
+    contract_ids = fields.One2many('hr.contract', string='Contracts', compute='_compute_contract_ids', readonly=True, compute_sudo=True)
     contract_count = fields.Integer(compute='_compute_contract_count', string="# Contracts")
     under_contract_state = fields.Selection([
         ('done', 'Under Contract'),
diff --git a/addons/hr_contract/security/security.xml b/addons/hr_contract/security/security.xml
index 3bbc0ae6a48..95fc3bbb929 100644
--- a/addons/hr_contract/security/security.xml
+++ b/addons/hr_contract/security/security.xml
@@ -8,14 +8,14 @@
 
         <record id="hr_contract.group_hr_contract_employee_manager" model="res.groups">
             <field name="name">Employee Manager</field>
-            <field name="category_id" ref="base.module_category_hidden"/>
+            <field name="category_id" ref="base.module_category_human_resources_contracts"/>
             <field name="implied_ids" eval="[(4, ref('base.group_user'))]"/>
         </record>
 
         <record id="hr_contract.group_hr_contract_manager" model="res.groups">
             <field name="name">Administrator</field>
             <field name="category_id" ref="base.module_category_human_resources_contracts"/>
-            <field name="implied_ids" eval="[(4, ref('hr_contract.group_hr_contract_employee_manager')), (4, ref('hr.group_hr_user'))]"/>
+            <field name="implied_ids" eval="[(4, ref('hr_contract.group_hr_contract_employee_manager'))]"/>
             <field name="users" eval="[(4, ref('base.user_root')), (4, ref('base.user_admin'))]"/>
         </record>