From 412561c37bf814ac11b16de60135256b89cef155 Mon Sep 17 00:00:00 2001 From: niv Date: Mon, 18 Oct 2010 12:35:57 +0200 Subject: [PATCH 1/6] [IMP] Modified Belgian accounting localization to have correct default tax account bzr revid: niv@niv-laptop-20101018103557-au9q9mzcf6ei8ijb --- addons/account/account.py | 10 +++-- addons/l10n_be/account_pcmn_belgium.xml | 50 +++++++++++++++++++++++++ 2 files changed, 56 insertions(+), 4 deletions(-) diff --git a/addons/account/account.py b/addons/account/account.py index f65f8edd56f..3f0784247cd 100644 --- a/addons/account/account.py +++ b/addons/account/account.py @@ -2874,10 +2874,12 @@ class wizard_multi_charts_accounts(osv.osv_memory): obj_ac_fp.create(cr, uid, vals_acc) ir_values = self.pool.get('ir.values') - ir_values.set(cr, uid, key='default', key2=False, name="taxes_id", company=obj_multi.company_id.id - , models =[('product.product',False)], value=[tax_template_to_tax[obj_multi.sale_tax.id]]) - ir_values.set(cr, uid, key='default', key2=False, name="supplier_taxes_id", company=obj_multi.company_id.id - , models =[('product.product',False)], value=[tax_template_to_tax[obj_multi.purchase_tax.id]]) + if obj_multi.sale_tax: + ir_values.set(cr, uid, key='default', key2=False, name="taxes_id", company=obj_multi.company_id.id + , models =[('product.product',False)], value=[tax_template_to_tax[obj_multi.sale_tax.id]]) + if obj_multi.purchase_tax: + ir_values.set(cr, uid, key='default', key2=False, name="supplier_taxes_id", company=obj_multi.company_id.id + , models =[('product.product',False)], value=[tax_template_to_tax[obj_multi.purchase_tax.id]]) wizard_multi_charts_accounts() diff --git a/addons/l10n_be/account_pcmn_belgium.xml b/addons/l10n_be/account_pcmn_belgium.xml index dc6c86fc9fa..7482250db8d 100644 --- a/addons/l10n_be/account_pcmn_belgium.xml +++ b/addons/l10n_be/account_pcmn_belgium.xml @@ -6666,6 +6666,7 @@ sale + 5 @@ -6676,6 +6677,7 @@ sale + 2 @@ -6690,6 +6692,7 @@ sale + 3 @@ -6704,6 +6707,7 @@ sale + 4 @@ -6718,6 +6722,7 @@ sale + 1 @@ -6732,6 +6737,7 @@ sale + 6 @@ -6744,6 +6750,7 @@ percent purchase + 7 @@ -6754,6 +6761,7 @@ purchase + 8 @@ -6764,6 +6772,7 @@ purchase + 9 @@ -6773,6 +6782,7 @@ percent purchase + 10 @@ -6783,6 +6793,7 @@ purchase + 11 @@ -6793,6 +6804,7 @@ purchase + 12 @@ -6802,6 +6814,7 @@ percent purchase + 13 @@ -6816,6 +6829,7 @@ purchase + 14 @@ -6826,6 +6840,7 @@ purchase + 15 @@ -6835,6 +6850,7 @@ percent purchase + 16 @@ -6849,6 +6865,7 @@ purchase + 17 @@ -6859,6 +6876,7 @@ purchase + 18 @@ -6868,6 +6886,7 @@ percent purchase + 19 @@ -6882,6 +6901,7 @@ purchase + 20 @@ -6892,6 +6912,7 @@ purchase + 21 @@ -6901,6 +6922,7 @@ percent purchase + 22 @@ -6915,6 +6937,7 @@ purchase + 23 @@ -6925,6 +6948,7 @@ purchase + 24 @@ -6936,6 +6960,7 @@ percent purchase + 25 @@ -6950,6 +6975,7 @@ purchase + 26 @@ -6960,6 +6986,7 @@ purchase + 27 @@ -6969,6 +6996,7 @@ percent purchase + 28 @@ -6983,6 +7011,7 @@ purchase + 29 @@ -6993,6 +7022,7 @@ purchase + 30 @@ -7002,6 +7032,7 @@ percent purchase + 31 @@ -7016,6 +7047,7 @@ purchase + 32 @@ -7026,6 +7058,7 @@ purchase + 33 @@ -7039,6 +7072,7 @@ sale + 34 @@ -7054,6 +7088,7 @@ purchase + 35 @@ -7068,6 +7103,7 @@ sale + 36 @@ -7078,6 +7114,7 @@ sale + 37 @@ -7088,6 +7125,7 @@ sale + 38 @@ -7100,6 +7138,7 @@ percent purchase + 39 @@ -7113,6 +7152,7 @@ purchase + 40 @@ -7128,6 +7168,7 @@ purchase + 41 @@ -7138,6 +7179,7 @@ purchase + 42 @@ -7147,6 +7189,7 @@ percent purchase + 43 @@ -7160,6 +7203,7 @@ purchase + 44 @@ -7175,6 +7219,7 @@ purchase + 45 @@ -7185,6 +7230,7 @@ purchase + 46 @@ -7194,6 +7240,7 @@ percent purchase + 47 @@ -7207,6 +7254,7 @@ purchase + 48 @@ -7222,6 +7270,7 @@ purchase + 49 @@ -7232,6 +7281,7 @@ purchase + 50 From a5f271f50de72282bbaaac624d14295eef7d51f4 Mon Sep 17 00:00:00 2001 From: nvi-openerp Date: Tue, 19 Oct 2010 16:48:45 +0200 Subject: [PATCH 2/6] [FIX] Fixed problem with hr when we use a addons_path with multiple paths bzr revid: nicolas.vanhoren@openerp.com-20101019144845-xaln01cug0hw8ykv --- addons/hr/hr.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/addons/hr/hr.py b/addons/hr/hr.py index 240511a03a0..d3cb41fc89d 100644 --- a/addons/hr/hr.py +++ b/addons/hr/hr.py @@ -184,9 +184,12 @@ class hr_employee(osv.osv): return {'value': {'work_email':mail.user_email}} def _get_photo(self, cr, uid, context=None): - return open(os.path.join( - tools.config['addons_path'], 'hr/image', 'photo.png'), - 'rb') .read().encode('base64') + paths = tools.config['addons_path'].split(",") + for path in paths: + full_path = os.path.join(path, 'hr/image', 'photo.png') + if os.path.exists(full_path): + return open(full_path,'rb') .read().encode('base64') + raise Exception("photo.png could not be found") _defaults = { 'active': 1, From 53d9dc8d8119728a7091d7c99eba83c1065ac7be Mon Sep 17 00:00:00 2001 From: nvi-openerp Date: Mon, 25 Oct 2010 12:05:42 +0200 Subject: [PATCH 3/6] [FIX] Fixed hr get_photo issue. bzr revid: nicolas.vanhoren@openerp.com-20101025100542-bfee6qo0t4e28269 --- addons/hr/hr.py | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/addons/hr/hr.py b/addons/hr/hr.py index f173e7f04ec..0f499c43ddd 100644 --- a/addons/hr/hr.py +++ b/addons/hr/hr.py @@ -25,6 +25,8 @@ from osv import fields, osv import tools from tools.translate import _ +import addons + class hr_employee_category(osv.osv): def name_get(self, cr, uid, ids, context=None): @@ -180,12 +182,8 @@ class hr_employee(osv.osv): return {'value': {'work_email' : work_email}} def _get_photo(self, cr, uid, context=None): - paths = tools.config['addons_path'].split(",") - for path in paths: - full_path = os.path.join(path, 'hr/image', 'photo.png') - if os.path.exists(full_path): - return open(full_path,'rb') .read().encode('base64') - raise Exception("photo.png could not be found") + res_path = addons.get_module_resource("hr","image/photo.png") + return open(res_path,'rb').read().encode('base64') _defaults = { 'active': 1, From e6a27d1f4faa773335d586f2bf2852c338101ead Mon Sep 17 00:00:00 2001 From: nvi-openerp Date: Mon, 25 Oct 2010 13:40:45 +0200 Subject: [PATCH 4/6] [IMP] Changed sequences in belgian accouting bzr revid: nicolas.vanhoren@openerp.com-20101025114045-onrpl83ngufo5lmt --- addons/l10n_be/account_pcmn_belgium.xml | 51 +------------------------ 1 file changed, 1 insertion(+), 50 deletions(-) diff --git a/addons/l10n_be/account_pcmn_belgium.xml b/addons/l10n_be/account_pcmn_belgium.xml index 7482250db8d..3471a184d62 100644 --- a/addons/l10n_be/account_pcmn_belgium.xml +++ b/addons/l10n_be/account_pcmn_belgium.xml @@ -6666,7 +6666,6 @@ sale - 5 @@ -6677,7 +6676,6 @@ sale - 2 @@ -6692,7 +6690,6 @@ sale - 3 @@ -6707,7 +6704,6 @@ sale - 4 @@ -6722,7 +6718,7 @@ sale - 1 + 0 @@ -6737,7 +6733,6 @@ sale - 6 @@ -6750,7 +6745,6 @@ percent purchase - 7 @@ -6761,7 +6755,6 @@ purchase - 8 @@ -6772,7 +6765,6 @@ purchase - 9 @@ -6782,7 +6774,6 @@ percent purchase - 10 @@ -6793,7 +6784,6 @@ purchase - 11 @@ -6804,7 +6794,6 @@ purchase - 12 @@ -6814,7 +6803,6 @@ percent purchase - 13 @@ -6829,7 +6817,6 @@ purchase - 14 @@ -6840,7 +6827,6 @@ purchase - 15 @@ -6850,7 +6836,6 @@ percent purchase - 16 @@ -6865,7 +6850,6 @@ purchase - 17 @@ -6876,7 +6860,6 @@ purchase - 18 @@ -6886,7 +6869,6 @@ percent purchase - 19 @@ -6901,7 +6883,6 @@ purchase - 20 @@ -6912,7 +6893,6 @@ purchase - 21 @@ -6922,7 +6902,6 @@ percent purchase - 22 @@ -6937,7 +6916,6 @@ purchase - 23 @@ -6948,7 +6926,6 @@ purchase - 24 @@ -6960,7 +6937,6 @@ percent purchase - 25 @@ -6975,7 +6951,6 @@ purchase - 26 @@ -6986,7 +6961,6 @@ purchase - 27 @@ -6996,7 +6970,6 @@ percent purchase - 28 @@ -7011,7 +6984,6 @@ purchase - 29 @@ -7022,7 +6994,6 @@ purchase - 30 @@ -7032,7 +7003,6 @@ percent purchase - 31 @@ -7047,7 +7017,6 @@ purchase - 32 @@ -7058,7 +7027,6 @@ purchase - 33 @@ -7072,7 +7040,6 @@ sale - 34 @@ -7088,7 +7055,6 @@ purchase - 35 @@ -7103,7 +7069,6 @@ sale - 36 @@ -7114,7 +7079,6 @@ sale - 37 @@ -7125,7 +7089,6 @@ sale - 38 @@ -7138,7 +7101,6 @@ percent purchase - 39 @@ -7152,7 +7114,6 @@ purchase - 40 @@ -7168,7 +7129,6 @@ purchase - 41 @@ -7179,7 +7139,6 @@ purchase - 42 @@ -7189,7 +7148,6 @@ percent purchase - 43 @@ -7203,7 +7161,6 @@ purchase - 44 @@ -7219,7 +7176,6 @@ purchase - 45 @@ -7230,7 +7186,6 @@ purchase - 46 @@ -7240,7 +7195,6 @@ percent purchase - 47 @@ -7254,7 +7208,6 @@ purchase - 48 @@ -7270,7 +7223,6 @@ purchase - 49 @@ -7281,7 +7233,6 @@ purchase - 50 From 3d8cbbdaaf9d7b4d6a2460a062cbfda634ec77b7 Mon Sep 17 00:00:00 2001 From: Olivier Dony Date: Mon, 25 Oct 2010 16:38:47 +0200 Subject: [PATCH 5/6] [IMP] share: corrected typo in share URL formatting patterns bzr revid: odo@openerp.com-20101025143847-lhcdroeyayydh71t --- addons/share/wizard/share_wizard.py | 4 ++-- addons/share/wizard/share_wizard_view.xml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/addons/share/wizard/share_wizard.py b/addons/share/wizard/share_wizard.py index 2d1fd252ecf..9349980933f 100644 --- a/addons/share/wizard/share_wizard.py +++ b/addons/share/wizard/share_wizard.py @@ -290,7 +290,7 @@ class share_create(osv.osv_memory): user_obj = self.pool.get('res.users') result_obj = self.pool.get('share.wizard.result.line') share_root_url = wizard_data.share_root_url - format_url = '%(login)' in share_root_url and '%(password)' in share_root_url + format_url = '%(login)s' in share_root_url and '%(password)s' in share_root_url existing_passwd_str = _('*usual password*') if wizard_data.user_type == 'new': for email in wizard_data.new_users.split('\n'): @@ -430,7 +430,7 @@ class share_create(osv.osv_memory): else: body += _("This additional data has been automatically added to your current access.\n") body += _("You may use your existing login and password to view it. As a reminder, your login is %s.\n") % result_line.login - + if not tools.email_send( user.user_email, email_to, diff --git a/addons/share/wizard/share_wizard_view.xml b/addons/share/wizard/share_wizard_view.xml index e6cade91c84..95fbc983c84 100644 --- a/addons/share/wizard/share_wizard_view.xml +++ b/addons/share/wizard/share_wizard_view.xml @@ -90,7 +90,7 @@ - 'action_id' (id of action) - 'domain' (string expression for full domain to apply as sent to server, with dynamic data like 'uid' replaced by actual value (i.e. after eval)!) - - 'share_root_url' : URL for direct access to share page (may include %(login) and %(password) placeholders) + - 'share_root_url' : URL for direct access to share page (may include %(login)s and %(password)s placeholders) --> Share Wizard @@ -106,7 +106,7 @@ - 'action_id' (id of action) - 'domain' (string expression for full domain to apply as sent to server, with dynamic data like 'uid' replaced by actual value (i.e. after eval)!) - - 'share_root_url' : URL for direct access to share page (may include %(login) and %(password) placeholders) + - 'share_root_url' : URL for direct access to share page (may include %(login)s and %(password)s placeholders) --> Share Wizard From 3572ed909a2294a876fa6329593d976dd94594bb Mon Sep 17 00:00:00 2001 From: Olivier Dony Date: Mon, 25 Oct 2010 16:54:45 +0200 Subject: [PATCH 6/6] [IMP] project: avoid access rights issue when reading time_mode (uom) for fields_view_get bzr revid: odo@openerp.com-20101025145445-ccgvic2uyqd50hi6 --- addons/project/project.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/addons/project/project.py b/addons/project/project.py index 294c711eaac..6c9f66dd009 100644 --- a/addons/project/project.py +++ b/addons/project/project.py @@ -483,7 +483,10 @@ class task(osv.osv): def fields_view_get(self, cr, uid, view_id=None, view_type='form', context=None, toolbar=False, submenu=False): users_obj = self.pool.get('res.users') - obj_tm = users_obj.browse(cr, uid, uid, context).company_id.project_time_mode_id + + # read uom as admin to avoid access rights issues, e.g. for portal/share users, + # this should be safe (no context passed to avoid side-effects) + obj_tm = users_obj.browse(cr, 1, uid).company_id.project_time_mode_id tm = obj_tm and obj_tm.name or 'Hours' res = super(task, self).fields_view_get(cr, uid, view_id, view_type, context, toolbar, submenu=submenu)