From 6cc5ebed1aec3d0fc8ed4a341dc7652ef2cb1422 Mon Sep 17 00:00:00 2001 From: Richard Mathot Date: Mon, 11 Dec 2017 11:10:55 +0100 Subject: [PATCH] [FIX] hr_holidays: prevent crash when no employee is linked to the user --- addons/hr_holidays/models/hr_holidays.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/addons/hr_holidays/models/hr_holidays.py b/addons/hr_holidays/models/hr_holidays.py index d967051f12d..fc72a6a9caf 100644 --- a/addons/hr_holidays/models/hr_holidays.py +++ b/addons/hr_holidays/models/hr_holidays.py @@ -270,10 +270,12 @@ class Holidays(models.Model): @api.onchange('holiday_type') def _onchange_type(self): if self.holiday_type == 'employee' and not self.employee_id: - self.employee_id = self.env.user.employee_ids[0] + if self.env.user.employee_ids: + self.employee_id = self.env.user.employee_ids[0] elif self.holiday_type == 'department': + if self.env.user.employee_ids: + self.department_id = self.department_id or self.env.user.employee_ids[0].department_id self.employee_id = None - self.department_id = self.department_id or self.env.user.employee_ids[0].department_id elif self.holiday_type == 'category': self.employee_id = None self.department_id = None