From 6cbbc5a1b7a9a0fa4efc260c8c4bf168fd60e103 Mon Sep 17 00:00:00 2001 From: "Maruan Aguerdouh (magm)" Date: Thu, 28 Mar 2024 13:41:37 +0100 Subject: [PATCH] [FIX] website_links: copy button will get the link in link tracker Issue: In Link Tracker for our website, when generating the link, if we try to copy the generated url with the copy value, instead of copying the url we are getting undefined. Steps to reproduce: 1. Install website_links. 2. Go to the website and go to Site > Link tracker. 3. Generate a new link and try to copy. Solution: Due to the recent changes that came from the changes made in 9638423 where we replace the ClipboardJS with Web API and hombrew polyfill, there are still some button that is not adapted yet, and in this case what happens is that we have a difference dataset format for the clipboard content, being 'clipboardText' instead of 'clipboard-text' opw-3806495 closes odoo/odoo#159674 Signed-off-by: Romain Derie (rde) --- addons/website_links/static/src/js/website_links.js | 2 +- addons/website_links/static/src/js/website_links_charts.js | 2 +- .../static/src/js/website_sale_gift_card.js | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/addons/website_links/static/src/js/website_links.js b/addons/website_links/static/src/js/website_links.js index b9690fa06cf..8074b04cb33 100644 --- a/addons/website_links/static/src/js/website_links.js +++ b/addons/website_links/static/src/js/website_links.js @@ -425,7 +425,7 @@ publicWidget.registry.websiteLinks = publicWidget.Widget.extend({ * @private */ _onShortenUrlButtonClick: async function (ev) { - const textValue = ev.target.dataset["clipboard-text"]; + const textValue = ev.target.dataset.clipboardText; await browser.navigator.clipboard.writeText(textValue); if (!$('#btn_shorten_url').hasClass('btn-copy') || this.url_copy_animating) { diff --git a/addons/website_links/static/src/js/website_links_charts.js b/addons/website_links/static/src/js/website_links_charts.js index 1768c0579fb..8f0110bc68e 100644 --- a/addons/website_links/static/src/js/website_links_charts.js +++ b/addons/website_links/static/src/js/website_links_charts.js @@ -290,7 +290,7 @@ publicWidget.registry.websiteLinksCharts = publicWidget.Widget.extend({ _onCopyToClipboardClick: async function (ev) { ev.preventDefault(); - const textValue = ev.target.dataset["clipboard-text"]; + const textValue = ev.target.dataset.clipboardText; await browser.navigator.clipboard.writeText(textValue); if (this.animating_copy) { diff --git a/addons/website_sale_loyalty/static/src/js/website_sale_gift_card.js b/addons/website_sale_loyalty/static/src/js/website_sale_gift_card.js index 0b213de9af5..64a21d91572 100644 --- a/addons/website_sale_loyalty/static/src/js/website_sale_gift_card.js +++ b/addons/website_sale_loyalty/static/src/js/website_sale_gift_card.js @@ -9,7 +9,7 @@ publicWidget.registry.WebsiteSaleGiftCardCopy = publicWidget.Widget.extend({ "click .copy-to-clipboard": "_onClickCopyToClipboard", }, async _onClickCopyToClipboard(ev) { - const textValue = ev.target.dataset["clipboard-text"]; + const textValue = ev.target.dataset.clipboardText; await browser.navigator.clipboard.writeText(textValue); }, });