From 6c73ed6f4b8372aba698e34e930c664829d19595 Mon Sep 17 00:00:00 2001 From: Florian Charlier Date: Fri, 2 Sep 2022 13:07:01 +0000 Subject: [PATCH] [REF] base,*: fix typo + privatize onboarding method * = account, sale - Fix typo - Make private as very specific role - Allows to grep similar functionality from new onboarding module and previous common implementation of onboardings. Task-2852375 Part of Task-2900763 Part-of: odoo/odoo#97105 --- addons/account/models/company.py | 4 ++-- addons/sale/models/res_company.py | 2 +- odoo/addons/base/models/res_company.py | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/addons/account/models/company.py b/addons/account/models/company.py index 5785b096074..61bdb338293 100644 --- a/addons/account/models/company.py +++ b/addons/account/models/company.py @@ -217,7 +217,7 @@ class ResCompany(models.Model): def get_and_update_account_invoice_onboarding_state(self): """ This method is called on the controller rendering method and ensures that the animations are displayed only one time. """ - return self.get_and_update_onbarding_state( + return self._get_and_update_onboarding_state( 'account_invoice_onboarding_state', self.get_account_invoice_onboarding_steps_states_names() ) @@ -234,7 +234,7 @@ class ResCompany(models.Model): def get_and_update_account_dashboard_onboarding_state(self): """ This method is called on the controller rendering method and ensures that the animations are displayed only one time. """ - return self.get_and_update_onbarding_state( + return self._get_and_update_onboarding_state( 'account_dashboard_onboarding_state', self.get_account_dashboard_onboarding_steps_states_names() ) diff --git a/addons/sale/models/res_company.py b/addons/sale/models/res_company.py index 90ce7d3acd5..257a06f43d8 100644 --- a/addons/sale/models/res_company.py +++ b/addons/sale/models/res_company.py @@ -130,6 +130,6 @@ class ResCompany(models.Model): 'sale_onboarding_order_confirmation_state', 'sale_onboarding_sample_quotation_state', ] - return self.get_and_update_onbarding_state('sale_quotation_onboarding_state', steps) + return self._get_and_update_onboarding_state('sale_quotation_onboarding_state', steps) _sql_constraints = [('check_quotation_validity_days', 'CHECK(quotation_validity_days > 0)', 'Quotation Validity is required and must be greater than 0.')] diff --git a/odoo/addons/base/models/res_company.py b/odoo/addons/base/models/res_company.py index 86b822eca8e..83b792c4edc 100644 --- a/odoo/addons/base/models/res_company.py +++ b/odoo/addons/base/models/res_company.py @@ -287,7 +287,7 @@ class Company(models.Model): if self[step_name] == 'not_done': self[step_name] = 'just_done' - def get_and_update_onbarding_state(self, onboarding_state, steps_states): + def _get_and_update_onboarding_state(self, onboarding_state, steps_states): """ Needed to display onboarding animations only one time. """ old_values = {} all_done = True