From 6c4fb8805e5ff354cf57f3b0bf2e7ccab747a3aa Mon Sep 17 00:00:00 2001
From: Pierre Paridans <app@odoo.com>
Date: Thu, 22 Sep 2022 11:57:37 +0000
Subject: [PATCH] [FIX] web: tags field placeholder when tag selected
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This commit properly removes the Many2ManyTagsField and
Many2ManyTagsAvatarField's placeholder when at least one tag has been
selected.

Steps to reproduce:
- In Contacts, open a partner's form view
- Edit and set at least one "tag"
- The placeholder is present next to the selected tags

Note: the placeholder was already present in previous versions.
Reported by FP.

closes odoo/odoo#101042

X-original-commit: 5976e19a31b9b0edaefc1079541514810d12b240
Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
---
 .../views/fields/many2many_tags/many2many_tags_field.xml   | 2 +-
 .../many2many_tags_avatar/many2many_tags_avatar_field.xml  | 2 +-
 .../tests/views/fields/many2many_tags_field_tests.js       | 7 +++++++
 3 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/addons/web/static/src/views/fields/many2many_tags/many2many_tags_field.xml b/addons/web/static/src/views/fields/many2many_tags/many2many_tags_field.xml
index 7f72881b91d..4cd771c6094 100644
--- a/addons/web/static/src/views/fields/many2many_tags/many2many_tags_field.xml
+++ b/addons/web/static/src/views/fields/many2many_tags/many2many_tags_field.xml
@@ -10,7 +10,7 @@
             <div t-if="showM2OSelectionField" class="o_field_many2many_selection d-inline-flex w-100" t-on-keydown="onAutoCompleteKeydown" t-ref="autoComplete">
                 <Many2XAutocomplete
                     id="props.id"
-                    placeholder="props.placeholder"
+                    placeholder="tags.length ? '' : props.placeholder"
                     resModel="props.relation"
                     autoSelect="true"
                     fieldString="string"
diff --git a/addons/web/static/src/views/fields/many2many_tags_avatar/many2many_tags_avatar_field.xml b/addons/web/static/src/views/fields/many2many_tags_avatar/many2many_tags_avatar_field.xml
index 514b60ed2eb..1ec6e08daab 100644
--- a/addons/web/static/src/views/fields/many2many_tags_avatar/many2many_tags_avatar_field.xml
+++ b/addons/web/static/src/views/fields/many2many_tags_avatar/many2many_tags_avatar_field.xml
@@ -10,7 +10,7 @@
             <div t-if="showM2OSelectionField" class="o_field_many2many_selection d-inline-flex w-100" t-on-keydown="onAutoCompleteKeydown" t-ref="autoComplete">
                 <Many2XAutocomplete
                     id="props.id"
-                    placeholder="props.placeholder"
+                    placeholder="tags.length ? '' : props.placeholder"
                     resModel="props.relation"
                     autoSelect="true"
                     fieldString="props.string"
diff --git a/addons/web/static/tests/views/fields/many2many_tags_field_tests.js b/addons/web/static/tests/views/fields/many2many_tags_field_tests.js
index cd7d1fa402a..7cccd6f41f5 100644
--- a/addons/web/static/tests/views/fields/many2many_tags_field_tests.js
+++ b/addons/web/static/tests/views/fields/many2many_tags_field_tests.js
@@ -1585,6 +1585,13 @@ QUnit.module("Fields", (hooks) => {
             target.querySelector(".o_field_widget[name='timmy'] input").placeholder,
             "Placeholder"
         );
+
+        await selectDropdownItem(target, "timmy", "gold");
+
+        assert.strictEqual(
+            target.querySelector(".o_field_widget[name='timmy'] input").placeholder,
+            ""
+        );
     });
 
     QUnit.test("Many2ManyTagsField supports 'create' props to be a Boolean", async (assert) => {