From 6c213203cbfaa9737853031d3dfee80c0a4cc1a6 Mon Sep 17 00:00:00 2001
From: Yannick Tivisse <yti@odoo.com>
Date: Wed, 14 Sep 2022 10:23:06 +0000
Subject: [PATCH] [IMP] base: Improve app uninstall wizard UX

Taskid: 2969678
Part-of: odoo/odoo#99438
---
 odoo/addons/base/static/src/css/modules.css   | 11 ++++-
 .../wizard/base_module_uninstall_views.xml    | 47 ++++++++++---------
 2 files changed, 33 insertions(+), 25 deletions(-)

diff --git a/odoo/addons/base/static/src/css/modules.css b/odoo/addons/base/static/src/css/modules.css
index 2582847255b..615116c3dac 100644
--- a/odoo/addons/base/static/src/css/modules.css
+++ b/odoo/addons/base/static/src/css/modules.css
@@ -12,12 +12,14 @@
     width: 77%;
 }
 
-.o_kanban_view .o_modules_kanban .oe_module_vignette {
+.o_kanban_view .o_modules_kanban .oe_module_vignette,
+.o_modules_field .o_modules_kanban .oe_module_vignette {
     align-items: center;
     display: flex;
 }
 
-.o_kanban_view .o_modules_kanban .o_kanban_record .o_dropdown_kanban {
+.o_kanban_view .o_modules_kanban .o_kanban_record .o_dropdown_kanban,
+.o_modules_field .o_modules_kanban .o_kanban_record .o_dropdown_kanban {
     visibility: visible;
     opacity: 0.5;
 }
@@ -27,6 +29,11 @@
     opacity: 1;
 }
 
+.o_modules_field .o_modules_kanban {
+    --KanbanRecord-width: 280px;
+    --KanbanRecord-width-small: 280px;
+}
+
 .oe_module_name > span  {
     color: #999999;
     min-height: 26px;
diff --git a/odoo/addons/base/wizard/base_module_uninstall_views.xml b/odoo/addons/base/wizard/base_module_uninstall_views.xml
index e167bc31aff..9d830c6e0b8 100644
--- a/odoo/addons/base/wizard/base_module_uninstall_views.xml
+++ b/odoo/addons/base/wizard/base_module_uninstall_views.xml
@@ -5,13 +5,21 @@
         <record id="view_base_module_uninstall" model="ir.ui.view">
             <field name="name">Uninstall module</field>
             <field name="model">base.module.uninstall</field>
+            <field name="type">form</field>
             <field name="arch" type="xml">
+                <div class="alert alert-warning mb-0" role="alert">
+                    <p class="mt-3">
+                        Uninstalling modules can be risky, we recommend you to try it on a duplicate or test database first.
+                    </p>
+                </div>
                 <form string="Uninstall module">
-                    <field name="module_id" groups="base.group_no_one"/>
-                    <h3>The following apps will be uninstalled</h3>
-                    <field name="show_all"/> Show technical modules
-                    <field name="module_ids" mode="kanban">
-                        <kanban create="false">
+                    <field name="module_id" invisible="1"/>
+                    <div class="d-flex bd-highlight">
+                        <div class="me-auto p-2 bd-highlight"><h3>Apps to Uninstall</h3></div>
+                        <div class="p-2 bd-highlight"><field name="show_all"/> Show All</div>
+                    </div>
+                    <field name="module_ids" mode="kanban" class="o_modules_field">
+                        <kanban create="false" class="o_modules_kanban">
                             <field name="icon"/>
                             <field name="state"/>
                             <field name="summary"/>
@@ -35,25 +43,18 @@
                                 </templates>
                         </kanban>
                     </field>
-                    <h3>The following documents will be permanently lost</h3>
-                    <field name="model_ids" string="Models">
-                        <tree string="Models">
-                            <field name="name" string="Document"/>
-                            <field name="count"/>
-                        </tree>
-                    </field>
-                    <div class="alert alert-warning" role="alert">
-                        <p class="mt-3">
-                            Module uninstallation is not always consistent and can sometimes lead to issues,
-                            some data may be deleted, the database could be left in an unstable state,
-                            the server could crash, etc. While this is rare, we recommend testing
-                            the uninstallation procedure on a duplicate database to guarantee that
-                            it works and then doing it on your production database.
-                        </p>
-                    </div>
+                    <h3>Documents to Delete</h3>
+                    <group>
+                        <field name="model_ids" string="Models" nolabel="1">
+                            <tree string="Models">
+                                <field name="name" string="Document"/>
+                                <field name="count"/>
+                            </tree>
+                        </field>
+                    </group>
                     <footer>
-                        <button string="Cancel" class="btn-primary" special="cancel" data-hotkey="z"/>
-                        <button string="Confirm" class="btn-secondary" type="object" name="action_uninstall" data-hotkey="q"/>
+                        <button string="Uninstall" class="btn-secondary" type="object" name="action_uninstall" data-hotkey="q"/>
+                        <button string="Discard" class="btn-primary" special="cancel" data-hotkey="z"/>
                     </footer>
                 </form>
             </field>