From 6bc1244c4fe5a8d79b40d419f089b70a04d10e3f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Thibault=20Delavall=C3=A9e?= <tde@odoo.com>
Date: Mon, 7 Jun 2021 08:37:45 +0000
Subject: [PATCH] [FIX] test_mail: clean tests about alias mixin

Just move some tests in their own class (test of alias mixin) and quickly clean
them.

Followup of odoo/odoo@7ae1b46

Task ID-2532529
PR odoo/odoo#71793
---
 addons/test_mail/tests/test_mail_gateway.py | 29 +++++++++++++--------
 1 file changed, 18 insertions(+), 11 deletions(-)

diff --git a/addons/test_mail/tests/test_mail_gateway.py b/addons/test_mail/tests/test_mail_gateway.py
index c75971e6228..90c834c990e 100644
--- a/addons/test_mail/tests/test_mail_gateway.py
+++ b/addons/test_mail/tests/test_mail_gateway.py
@@ -177,22 +177,29 @@ class TestMailAlias(TestMailCommon):
         with self.assertRaises(exceptions.UserError), self.cr.savepoint():
             self.env['ir.config_parameter'].sudo().set_param('mail.bounce.alias', new_mail_alias.alias_name)
 
-    def test_alias_mixin_copy(self):
-        user_demo = self.env.ref('base.user_demo')
-        self.assertFalse(user_demo.has_group('base.group_system'), 'Demo user is not supposed to have Administrator access')
-        self._test_alias_mixin_copy(user_demo, 'alias.test1', False)
-        self._test_alias_mixin_copy(user_demo, 'alias.test2', '<p>What Is Dead May Never Die</p>')
 
-    def _test_alias_mixin_copy(self, user, alias_name, alias_bounced_content):
-        record = self.env['mail.test.container'].with_user(user).with_context(lang='en_US').create({
+@tagged('mail_gateway')
+class TestMailAliasMixin(TestMailCommon):
+
+    @users('employee')
+    def test_alias_mixin_copy_content(self):
+        self.assertFalse(self.env.user.has_group('base.group_system'), 'Test user should not have Administrator access')
+
+        record = self.env['mail.test.container'].create({
             'name': 'Test Record',
-            'alias_name': alias_name,
+            'alias_name': 'test.record',
             'alias_contact': 'followers',
-            'alias_bounced_content': alias_bounced_content,
+            'alias_bounced_content': False,
         })
-        self.assertEqual(record.alias_bounced_content, alias_bounced_content)
+        self.assertFalse(record.alias_bounced_content)
         record_copy = record.copy()
-        self.assertEqual(record_copy.alias_bounced_content, alias_bounced_content)
+        self.assertFalse(record_copy.alias_bounced_content)
+
+        new_content = '<p>Bounced Content</p>'
+        record_copy.write({'alias_bounced_content': new_content})
+        self.assertEqual(record_copy.alias_bounced_content, new_content)
+        record_copy2 = record_copy.copy()
+        self.assertEqual(record_copy2.alias_bounced_content, new_content)
 
 
 @tagged('mail_gateway')