From 6bb1a8cd61cc8d9ec3d3382aef36d417f457ea73 Mon Sep 17 00:00:00 2001
From: Jason Van Malder <jvm@odoo.com>
Date: Thu, 9 Jan 2020 07:01:36 +0000
Subject: [PATCH] [FIX] web: fix planning roles filter disappearing

Issue

    - Install planning
    - Go on a planning view where you have 2 filters (employee/roles)
    - Unselect all items of one filter

    All the filters disappear.

Cause

    By doing this:

    ```
    if (!_.find(options.filters, function (f) {return f.display == null || f.display;})) {
        return;
    }
    ```

    We break the function's recursion:
    ```
    return self._renderFiltersOneByOne(filterIndex + 1);
    ```

    So the others filters are not rendered.

Solution

    Return the next filter rendering instead of nothing.

OPW-2166932

closes #42703, closes #42433

closes odoo/odoo#43025

X-original-commit: dbab68a92ec48b2bb6f21244af1de56691cb43f1
Signed-off-by: Jason Van Malder <jvm-odoo@users.noreply.github.com>
---
 addons/web/static/src/js/views/calendar/calendar_renderer.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/addons/web/static/src/js/views/calendar/calendar_renderer.js b/addons/web/static/src/js/views/calendar/calendar_renderer.js
index 597f20d8239..a22f39ec4ec 100644
--- a/addons/web/static/src/js/views/calendar/calendar_renderer.js
+++ b/addons/web/static/src/js/views/calendar/calendar_renderer.js
@@ -625,7 +625,7 @@ return AbstractRenderer.extend({
         if (filterIndex < arrFilters.length) {
             var options = arrFilters[filterIndex];
             if (!_.find(options.filters, function (f) {return f.display == null || f.display;})) {
-                return;
+                return this._renderFiltersOneByOne(filterIndex + 1);
             }
 
             var self = this;