From 6b7ecc51b7f238499f8ca8fdfd8276f6186c6f0e Mon Sep 17 00:00:00 2001
From: Martin Geubelle <mge@odoo.com>
Date: Tue, 16 Jun 2015 14:13:43 +0200
Subject: [PATCH] [IMP] cross addons: improve kanban views (deprecated classes,
 extra li, etc.)

---
 .../src/less/account_journal_dashboard.less   | 37 ++++++++++---------
 .../views/account_journal_dashboard_view.xml  |  2 +-
 addons/hr/hr_dashboard.xml                    |  4 +-
 .../hr_recruitment_dashboard.xml              |  4 +-
 .../src/less/hr_recruitment_dashboard.less    |  4 +-
 addons/product/product_view.xml               |  2 +-
 addons/project/project_dashboard.xml          |  6 +--
 addons/sales_team/sales_team.xml              |  1 -
 addons/sales_team/sales_team_dashboard.xml    |  4 +-
 .../static/src/less/sales_team_dashboard.less |  7 ----
 addons/stock/stock_dashboard.xml              |  4 +-
 openerp/addons/base/res/res_partner_view.xml  |  4 +-
 12 files changed, 36 insertions(+), 43 deletions(-)
 delete mode 100644 addons/sales_team/static/src/less/sales_team_dashboard.less

diff --git a/addons/account/static/src/less/account_journal_dashboard.less b/addons/account/static/src/less/account_journal_dashboard.less
index f18ec80415b..0ded24f5d64 100644
--- a/addons/account/static/src/less/account_journal_dashboard.less
+++ b/addons/account/static/src/less/account_journal_dashboard.less
@@ -1,20 +1,21 @@
-.oe_kanban_view.o_kanban_dashboard.o_account_kanban {
-	.oe_kanban_record {
-		min-width: 500px;
-		max-width: 650px;
-	}
-	.o_kanban_card_settings {
-		padding: 8px;
+.o_kanban_view.o_kanban_dashboard.o_account_kanban {
+    .o_kanban_record {
+        min-width: 500px;
+        max-width: 650px;
 
-        border-color: lightgrey;
-        border-top-style: solid;
-        border-top-width: 1px;
-	}
-	.o_kanban_graph_section {
-		padding: 16px;
-	}
-	.o_dashboard_star {
-		font-size: 12px;
-		margin-left: 5px;
-	}
+        .o_kanban_card_settings {
+            padding: 8px;
+
+            border-color: lightgrey;
+            border-top-style: solid;
+            border-top-width: 1px;
+        }
+        .o_kanban_graph_section {
+            padding: 16px;
+        }
+        .o_dashboard_star {
+            font-size: 12px;
+            margin-left: 5px;
+        }
+    }
 }
diff --git a/addons/account/views/account_journal_dashboard_view.xml b/addons/account/views/account_journal_dashboard_view.xml
index 5ebe9e36659..24f2d9dc0c6 100644
--- a/addons/account/views/account_journal_dashboard_view.xml
+++ b/addons/account/views/account_journal_dashboard_view.xml
@@ -40,7 +40,7 @@
                                 </div>
                             </div>
                             <div class="o_kanban_manage_button_section">
-                                <a class="o_kanban_manage_toggle_button">More <i class="fa fa-caret-down"/></a>
+                                <a class="o_kanban_manage_toggle_button" href="#">More <i class="fa fa-caret-down"/></a>
                             </div>
                         </div>
                     </t>
diff --git a/addons/hr/hr_dashboard.xml b/addons/hr/hr_dashboard.xml
index 9567eda3ed7..4f77fa309c2 100644
--- a/addons/hr/hr_dashboard.xml
+++ b/addons/hr/hr_dashboard.xml
@@ -17,7 +17,7 @@
                                     <div class="o_secondary"><field name="company_id"/></div>
                                 </div>
                                 <div class="o_kanban_manage_button_section">
-                                    <a class="o_kanban_manage_toggle_button">More <i class="fa fa-caret-down"/></a>
+                                    <a class="o_kanban_manage_toggle_button" href="#">More <i class="fa fa-caret-down"/></a>
                                 </div>
                             </div>
                             <div class="container o_kanban_card_content o_visible">
@@ -49,7 +49,7 @@
 
                                 <div t-if="widget.editable" class="o_kanban_card_manage_settings row">
                                     <div class="col-xs-8">
-                                        <li><ul class="oe_kanban_colorpicker" data-field="color"/></li>
+                                        <ul class="oe_kanban_colorpicker" data-field="color"/>
                                     </div>
                                     <div class="col-xs-4 text-right">
                                         <a type="edit">Settings</a>
diff --git a/addons/hr_recruitment/hr_recruitment_dashboard.xml b/addons/hr_recruitment/hr_recruitment_dashboard.xml
index e0965de2039..01e95fc5f28 100644
--- a/addons/hr_recruitment/hr_recruitment_dashboard.xml
+++ b/addons/hr_recruitment/hr_recruitment_dashboard.xml
@@ -39,7 +39,7 @@
                                     </div>
                                 </div>
                                 <div class="o_kanban_manage_button_section">
-                                    <a class="o_kanban_manage_toggle_button">More <i class="fa fa-caret-down"/></a>
+                                    <a class="o_kanban_manage_toggle_button" href="#">More <i class="fa fa-caret-down"/></a>
                                 </div>
                             </div>
                             <div class="container o_kanban_card_content o_visible">
@@ -125,7 +125,7 @@
 
                                 <div t-if="widget.editable" class="o_kanban_card_manage_settings row">
                                     <div class="col-xs-8">
-                                        <li><ul class="oe_kanban_colorpicker" data-field="color"/></li>
+                                        <ul class="oe_kanban_colorpicker" data-field="color"/>
                                     </div>
                                     <div class="col-xs-4 text-right">
                                         <a type="edit">Settings</a>
diff --git a/addons/hr_recruitment/static/src/less/hr_recruitment_dashboard.less b/addons/hr_recruitment/static/src/less/hr_recruitment_dashboard.less
index 6177dd1df9d..e1a784890a3 100644
--- a/addons/hr_recruitment/static/src/less/hr_recruitment_dashboard.less
+++ b/addons/hr_recruitment/static/src/less/hr_recruitment_dashboard.less
@@ -1,5 +1,5 @@
-.oe_kanban_view.o_kanban_dashboard.o_hr_recruitment_kanban {
-	.oe_kanban_record {
+.o_kanban_view.o_kanban_dashboard.o_hr_recruitment_kanban {
+	.o_kanban_record {
 		max-width: 500px;
 		min-width: 450px;
 
diff --git a/addons/product/product_view.xml b/addons/product/product_view.xml
index b6b4f7b7033..53a190e991d 100644
--- a/addons/product/product_view.xml
+++ b/addons/product/product_view.xml
@@ -403,7 +403,7 @@
                                     <field name="attribute_value_ids"/>
                                 </div>
                                 <div class="o_kanban_image">
-                                    <img t-att-src="kanban_image('product.product', 'image_small', record.id.value)" class="oe_kanban_image"/>
+                                    <img t-att-src="kanban_image('product.product', 'image_small', record.id.value)" class="o_kanban_image"/>
                                 </div>
                                 <div class="oe_kanban_details">
                                     <strong><field name="name"/></strong>
diff --git a/addons/project/project_dashboard.xml b/addons/project/project_dashboard.xml
index 9d23ad05f40..1996e3b4cf9 100644
--- a/addons/project/project_dashboard.xml
+++ b/addons/project/project_dashboard.xml
@@ -41,9 +41,9 @@
                                         <div>
                                             <a name="%(action_view_task_history_cumulative_filter)d" type="action">Cumulative Flow</a>
                                         </div>
-                                        <div t-if="widget.editable" class="o_project_kanban_colorpicker">
-                                            <ul class="oe_kanban_colorpicker" data-field="color"/>
-                                        </div>
+                                    </div>
+                                    <div t-if="widget.editable" class="o_project_kanban_colorpicker">
+                                        <ul class="oe_kanban_colorpicker" data-field="color"/>
                                     </div>
                                 </div>
                                 <div class="o_project_kanban_manage">
diff --git a/addons/sales_team/sales_team.xml b/addons/sales_team/sales_team.xml
index 1786272c364..548c52e7bc1 100644
--- a/addons/sales_team/sales_team.xml
+++ b/addons/sales_team/sales_team.xml
@@ -152,7 +152,6 @@
         <template id="assets_backend" name="sales_team assets" inherit_id="web.assets_backend">
             <xpath expr="." position="inside">
                 <link rel="stylesheet" href="/sales_team/static/src/css/sales_team.css"/>
-                <link rel="stylesheet" href="/sales_team/static/src/less/sales_team_dashboard.less"/>
                 <script type="text/javascript" src="/sales_team/static/src/js/sales_team.js"></script>
             </xpath>
         </template>
diff --git a/addons/sales_team/sales_team_dashboard.xml b/addons/sales_team/sales_team_dashboard.xml
index 33e5a7062c5..64631744f79 100644
--- a/addons/sales_team/sales_team_dashboard.xml
+++ b/addons/sales_team/sales_team_dashboard.xml
@@ -18,7 +18,7 @@
                                     <div class="o_primary"><field name="name"/></div>
                                 </div>
                                 <div class="o_kanban_manage_button_section">
-                                    <a class="o_kanban_manage_toggle_button">More <i class="fa fa-caret-down"/></a>
+                                    <a class="o_kanban_manage_toggle_button" href="#">More <i class="fa fa-caret-down"/></a>
                                 </div>
                             </div>
                             <div class="container o_kanban_card_content o_visible">
@@ -49,7 +49,7 @@
 
                                 <div t-if="widget.editable" class="o_kanban_card_manage_settings row">
                                     <div class="col-xs-8">
-                                        <li><ul class="oe_kanban_colorpicker" data-field="color"/></li>
+                                        <ul class="oe_kanban_colorpicker" data-field="color"/>
                                     </div>
                                     <div class="col-xs-4 text-right">
                                         <a type="edit">Settings</a>
diff --git a/addons/sales_team/static/src/less/sales_team_dashboard.less b/addons/sales_team/static/src/less/sales_team_dashboard.less
deleted file mode 100644
index 19dbb66757a..00000000000
--- a/addons/sales_team/static/src/less/sales_team_dashboard.less
+++ /dev/null
@@ -1,7 +0,0 @@
-.oe_kanban_view.o_kanban_dashboard.o_salesteam_kanban {
-	.oe_kanban_record {
-		min-height: 200px;
-		min-width: 500px;
-		max-width: 600px;
-	}
-}
\ No newline at end of file
diff --git a/addons/stock/stock_dashboard.xml b/addons/stock/stock_dashboard.xml
index 002a7fa3f87..a2a62779f7d 100644
--- a/addons/stock/stock_dashboard.xml
+++ b/addons/stock/stock_dashboard.xml
@@ -21,7 +21,7 @@
                                     <div class="o_secondary"><field class="o_secondary"  name="warehouse_id"/></div>
                                 </div>
                                 <div class="o_kanban_manage_button_section">
-                                    <a class="o_kanban_manage_toggle_button">More <i class="fa fa-caret-down"/></a>
+                                    <a class="o_kanban_manage_toggle_button" href="#">More <i class="fa fa-caret-down"/></a>
                                 </div>
                             </div>
                             <div class="container o_kanban_card_content o_visible">
@@ -102,7 +102,7 @@
 
                                 <div t-if="widget.editable" class="o_kanban_card_manage_settings row">
                                     <div class="col-xs-8">
-                                        <li><ul class="oe_kanban_colorpicker" data-field="color"/></li>
+                                        <ul class="oe_kanban_colorpicker" data-field="color"/>
                                     </div>
                                     <div class="col-xs-4 text-right">
                                         <a type="edit">Settings</a>
diff --git a/openerp/addons/base/res/res_partner_view.xml b/openerp/addons/base/res/res_partner_view.xml
index 8d3865c9a7e..351b02fe587 100644
--- a/openerp/addons/base/res/res_partner_view.xml
+++ b/openerp/addons/base/res/res_partner_view.xml
@@ -221,10 +221,10 @@
                                                     </t>
                                                     <t t-if="!record.image.raw_value">
                                                         <t t-if="record.is_company.raw_value === true">
-                                                            <img t-att-src='_s + "/base/static/src/img/company_image.png"' class="oe_kanban_image oe_kanban_avatar_smallbox"/>
+                                                            <img t-att-src='_s + "/base/static/src/img/company_image.png"' class="o_kanban_image oe_kanban_avatar_smallbox"/>
                                                         </t>
                                                         <t t-if="record.is_company.raw_value === false">
-                                                            <img t-att-src='_s + "/base/static/src/img/avatar.png"' class="oe_kanban_image oe_kanban_avatar_smallbox"/>
+                                                            <img t-att-src='_s + "/base/static/src/img/avatar.png"' class="o_kanban_image oe_kanban_avatar_smallbox"/>
                                                         </t>
                                                     </t>
                                                 </a>